Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused imports #1381

Merged
merged 1 commit into from
Dec 1, 2020
Merged

refactor: remove unused imports #1381

merged 1 commit into from
Dec 1, 2020

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 1, 2020

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner December 1, 2020 15:46
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/docker labels Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1381 (5bd49d7) into master (41cc787) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
+ Coverage   83.52%   83.55%   +0.03%     
==========================================
  Files         103      103              
  Lines        6793     6861      +68     
==========================================
+ Hits         5674     5733      +59     
- Misses       1119     1128       +9     
Impacted Files Coverage Δ
jina/docker/hubio.py 70.91% <100.00%> (-0.09%) ⬇️
jina/drivers/querylang/select.py 79.31% <0.00%> (-6.90%) ⬇️
jina/peapods/grpc_asyncio.py 75.51% <0.00%> (-5.11%) ⬇️
jina/logging/sse.py 92.64% <0.00%> (-2.52%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/peapods/pod.py 83.18% <0.00%> (-0.10%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
jina/executors/evaluators/text/length.py 100.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c564ef...5bd49d7. Read the comment docs.

Copy link
Contributor

@rutujasurve94 rutujasurve94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit be1d5b7 into master Dec 1, 2020
@JoanFM JoanFM deleted the refactor-unused-imports branch December 1, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/docker size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants