Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): move extract embeddings and contents into docset #1387

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 2, 2020

Note: __str__ and __repr__ on Jina types are out of scope of this PR

@hanxiao hanxiao requested a review from a team as a code owner December 2, 2020 16:46
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/type labels Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #1387 (ea1acae) into master (b598437) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   83.43%   83.58%   +0.15%     
==========================================
  Files         103      103              
  Lines        6792     6861      +69     
==========================================
+ Hits         5667     5735      +68     
- Misses       1125     1126       +1     
Impacted Files Coverage Δ
jina/drivers/encode.py 88.23% <100.00%> (-0.66%) ⬇️
jina/drivers/index.py 94.73% <100.00%> (-0.27%) ⬇️
jina/drivers/predict.py 89.83% <100.00%> (-0.17%) ⬇️
jina/drivers/search.py 94.64% <100.00%> (-0.10%) ⬇️
jina/types/document/helper.py 100.00% <100.00%> (ø)
jina/types/sets/document_set.py 98.71% <100.00%> (+0.47%) ⬆️
jina/peapods/grpc_asyncio.py 75.51% <0.00%> (-1.03%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/peapods/pod.py 83.18% <0.00%> (-0.10%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b598437...f3d4d15. Read the comment docs.

@hanxiao hanxiao merged commit 56d37f9 into master Dec 2, 2020
@hanxiao hanxiao deleted the refactor-docset branch December 2, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/type size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants