refactor: updated helloworld.html to fix a typo #1405
Conversation
jina-bot
added
size/S
area/core
harry-stark
changed the title
jina/resources/helloworld.html
Outdated
| <h2 style="color: #1E6E73">What just happened?</h2> | ||
| <span>This is Jina's <pre style="display: inline;">hello-world</pre>,end-to-endly. It downloads Fashion-MNIST dataset and indexes 60,000 images via Jina search framework. The index is stored into multiple <i>shards</i>. We then randomly sample unseen images as <i>Queries</i>, ask Jina to retrieve relevant results. Below is Jina's retrievals, where the left-most column is query image.</span> | ||
| <br> | ||
| <span> Intrigued? Learn more about Jina and <a href="https://opensource.jina.ai">checkout our Github!</a></span> |
There was a problem hiding this comment.
That should point to https://get.jina.ai/ since it is where the Readme is displayed.
jina/resources/helloworld.html
Outdated
| <div | ||
| class="about" style="max-width: 50%;padding: 10px;"> | ||
| <h2 style="color: #1E6E73">What just happened?</h2> | ||
| <span>This is Jina's <pre style="display: inline;">hello-world</pre>,end-to-endly. It downloads Fashion-MNIST dataset and indexes 60,000 images via Jina search framework. The index is stored into multiple <i>shards</i>. We then randomly sample unseen images as <i>Queries</i>, ask Jina to retrieve relevant results. Below is Jina's retrievals, where the left-most column is query image.</span> |
There was a problem hiding this comment.
a space missing , end-to-endly.
|
Hello @harry-stark, please change the commit message. Our lint complains about the full-stop in the You can amend your commit and change it! |
|
The commit message of the first commit still contains a full stop |
|
recheckcla |
|
Jina CLA check I have read the CLA Document and I hereby sign the CLA 1 out of 4 committers have signed the CLA. |
* docs: added code review guide
Minor changes included as requested
jina-bot
added
size/L
area/entrypoint
|
@maximilianwerk Hey max I did the changes you requested as well the commit messages are now in line with the contribution guide. |
|
I have read the CLA Document and I hereby sign the CLA |
Codecov Report
@@ Coverage Diff @@
## master #1405 +/- ##
==========================================
- Coverage 81.89% 81.86% -0.04%
==========================================
Files 106 106
Lines 6970 7040 +70
==========================================
+ Hits 5708 5763 +55
- Misses 1262 1277 +15
Continue to review full report at Codecov.
|
|
Hey @harry-stark I think you messed up a little bit with you last merge of master into your branch. You can try repairing this on this branch, but I believe the easiest way is: Create a new branch from master on you fork, copy the code changes onto this new branch and make one commit with the right commit message. Afterwards create a new PR with this fresh branch. Cheers and thank you a lot for your contribution. Well appreciated. |
updating Repo
|
@maximilianwerk Hey max I repaired it and this time it also passed all the tests. We can try from this last time otherwise I can open a fresh PR. I think while I was improving the commit messages, some other changes would have been pushed at the same time resulting in the previous mess. Hopefully,this time it works. |
|
Hey @harry-stark the result looks better now. Anyhow, the commit history will be tainted in this way, since you included several unrelated commits on the go. Please open a new PR with a fresh branch where only your commits are included. |
let's maybe just squash and merge @maximilianwerk ? |
There was a repeated segment in helloworld.html and the document itself was crammed so I restructured it.