Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newline at the end #1425

Merged
merged 1 commit into from
Dec 10, 2020
Merged

add newline at the end #1425

merged 1 commit into from
Dec 10, 2020

Conversation

lsgrep
Copy link
Contributor

@lsgrep lsgrep commented Dec 10, 2020

Without the newline, it could mess things up if the user installs something else after Jina's installation.

Screen Shot 2020-12-10 at 2 53 47 PM

@lsgrep lsgrep requested a review from a team as a code owner December 10, 2020 06:54
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/resource labels Dec 10, 2020
@JoanFM
Copy link
Member

JoanFM commented Dec 10, 2020

Thank you for the contribution, however your commit does not pass our lint check
please refer to:

@JoanFM
Copy link
Member

JoanFM commented Dec 10, 2020

recheckcla

@github-actions
Copy link

Jina CLA check

❤️ Thank you for your pull request. It looks like this is your first contribution to an open source project maintained by Jina AI Limited. Before we can look at your pull request, we kindly ask that you sign our Contributor License Agreement. You can sign it by commenting in format below.


I have read the CLA Document and I hereby sign the CLA


@lsgrep
Copy link
Contributor Author

lsgrep commented Dec 10, 2020

I have read the CLA Document and I hereby sign the CLA

@lsgrep
Copy link
Contributor Author

lsgrep commented Dec 10, 2020

Hi @JoanFM, I've updated the commit message.

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #1425 (a75b148) into master (0094bbf) will decrease coverage by 0.07%.
The diff coverage is 76.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   82.21%   82.14%   -0.08%     
==========================================
  Files         106      113       +7     
  Lines        7064     7165     +101     
==========================================
+ Hits         5808     5886      +78     
- Misses       1256     1279      +23     
Impacted Files Coverage Δ
jina/drivers/craft.py 100.00% <ø> (ø)
jina/drivers/querylang/slice.py 93.75% <ø> (ø)
jina/logging/profile.py 55.81% <ø> (-0.66%) ⬇️
jina/peapods/peas/gateway/grpc/helper.py 0.00% <0.00%> (ø)
jina/peapods/pods/remote.py 0.00% <0.00%> (ø)
jina/types/sets/document.py 96.47% <ø> (ø)
jina/types/sets/querylang.py 61.66% <ø> (ø)
jina/peapods/peas/remote/__init__.py 33.33% <33.33%> (ø)
jina/peapods/pods/flow.py 62.68% <62.68%> (ø)
jina/peapods/peas/remote/ssh.py 36.58% <66.66%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916931b...a5ed676. Read the comment docs.

@JoanFM
Copy link
Member

JoanFM commented Dec 10, 2020

Thank you very much for your contribution @lsgrep !!

@JoanFM JoanFM merged commit 576c4bd into jina-ai:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/resource size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants