Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grpc): rename the file and class #1428

Merged
merged 4 commits into from
Dec 10, 2020
Merged

fix(grpc): rename the file and class #1428

merged 4 commits into from
Dec 10, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 10, 2020

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner December 10, 2020 11:02
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality component/peapod labels Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020 •
edited
Loading

Codecov Report

Merging #1428 (e9c4c88) into master (576c4bd) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
- Coverage   82.15%   82.05%   -0.10%     
==========================================
  Files         113      113              
  Lines        7095     7095              
==========================================
- Hits         5829     5822       -7     
- Misses       1266     1273       +7
Impacted Files Coverage Δ
jina/peapods/peas/gateway/grpc/__init__.py 77.55% <100.00%> (ø)
jina/peapods/peas/gateway/grpc/async_server.py 87.50% <100.00%> (ø)
jina/peapods/zmq/__init__.py 82.02% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1813c63...34185e2. Read the comment docs.

@hanxiao hanxiao merged commit 4bf2780 into master Dec 10, 2020
@hanxiao hanxiao deleted the fix-grpc-filename branch December 10, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang Awaiting requested review from nan-wang

@bhavsarpratik bhavsarpratik Awaiting requested review from bhavsarpratik

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanxiao @jina-bot