Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor unit tests in hubapi #1589

Merged
merged 2 commits into from Jan 5, 2021
Merged

refactor unit tests in hubapi #1589

merged 2 commits into from Jan 5, 2021

Conversation

nan-wang
Copy link
Member

@nan-wang nan-wang commented Jan 5, 2021

refactor unit tests in hubapi

@nan-wang nan-wang requested a review from a team as a code owner January 5, 2021 03:57
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/docker labels Jan 5, 2021
Copy link
Contributor

@rutujasurve94 rutujasurve94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1589 (a91c689) into master (35139e9) will increase coverage by 0.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1589      +/-   ##
==========================================
+ Coverage   83.44%   84.30%   +0.85%     
==========================================
  Files         128      128              
  Lines        6646     6646              
==========================================
+ Hits         5546     5603      +57     
+ Misses       1100     1043      -57     
Impacted Files Coverage Δ
jina/docker/hubapi.py 80.83% <ø> (+7.78%) ⬆️
jina/flow/base.py 86.98% <0.00%> (+0.51%) ⬆️
jina/logging/sse.py 95.31% <0.00%> (+3.12%) ⬆️
jina/docker/hubio.py 71.86% <0.00%> (+10.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453fd20...a91c689. Read the comment docs.

@nan-wang nan-wang merged commit f0222dc into master Jan 5, 2021
@nan-wang nan-wang deleted the refactor-test-hubapi branch January 5, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/docker size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants