Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import): add requests decorator to top-level import #2317

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 20, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner April 20, 2021 03:36
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality component/executor executor/meta labels Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2317 (ef7d699) into master (29a9c02) will increase coverage by 1.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
+ Coverage   89.26%   91.00%   +1.73%     
==========================================
  Files         222      222              
  Lines       11791    11792       +1     
==========================================
+ Hits        10525    10731     +206     
+ Misses       1266     1061     -205     
Flag Coverage Δ
daemon 51.06% <100.00%> (+<0.01%) ⬆️
jina 91.17% <100.00%> (+1.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/decorators.py 87.26% <ø> (ø)
jina/__init__.py 74.71% <100.00%> (+0.29%) ⬆️
jina/flow/base.py 92.63% <0.00%> (+0.25%) ⬆️
jina/drivers/evaluate.py 100.00% <0.00%> (+1.40%) ⬆️
jina/helper.py 83.72% <0.00%> (+2.15%) ⬆️
jina/parsers/helloworld.py 98.21% <0.00%> (+3.57%) ⬆️
jina/logging/profile.py 96.09% <0.00%> (+3.90%) ⬆️
jina/peapods/runtimes/jinad/client.py 87.59% <0.00%> (+5.10%) ⬆️
jina/executors/devices.py 56.86% <0.00%> (+5.88%) ⬆️
jina/drivers/convert.py 97.22% <0.00%> (+8.33%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f44e8...ef7d699. Read the comment docs.

@hanxiao hanxiao merged commit 816e183 into master Apr 20, 2021
@hanxiao hanxiao deleted the fix-import-and-doc branch April 20, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality component/executor executor/meta size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants