-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor is ready #2833
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2833 +/- ##
==========================================
+ Coverage 82.21% 89.10% +6.88%
==========================================
Files 106 138 +32
Lines 7064 9371 +2307
==========================================
+ Hits 5808 8350 +2542
+ Misses 1256 1021 -235
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we may add some wrapper later in the base runtime to hide the event implementation from the concrete runtimes, but that does not change too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there are some tests failing which look legit: https://github.com/jina-ai/jina/pull/2833/checks?check_run_id=2969742801
Changes introduced
We are currently setting
is_ready
before the runtime is actually really ready to handle traffic. This PR gives the responsability to setis_ready
flag to theruntime
and tries to make sure thatis_ready
is more meaningful.It also allows us to avoid the need to call
terminate
and have a potentially more grateful shutdown