Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add readme snippet to CI #2847

Merged
merged 6 commits into from
Jul 4, 2021
Merged

fix: add readme snippet to CI #2847

merged 6 commits into from
Jul 4, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jul 4, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner July 4, 2021 08:32
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client labels Jul 4, 2021
@codecov
Copy link

codecov bot commented Jul 4, 2021 •
edited

Codecov Report

Merging #2847 (9a11dae) into master (0094bbf) will increase coverage by 3.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2847      +/-   ##
==========================================
+ Coverage   82.21%   85.49%   +3.27%     
==========================================
  Files         106      138      +32     
  Lines        7064     9365    +2301     
==========================================
+ Hits         5808     8007    +2199     
- Misses       1256     1358     +102
Flag Coverage Δ
daemon 47.02% <ø> (?)
jina 84.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.64% <ø> (ø)
jina/checker.py 0.00% <ø> (ø)
jina/clients/__init__.py 100.00% <ø> (ø)
jina/clients/base/__init__.py 90.90% <ø> (ø)
jina/clients/base/grpc.py 63.82% <ø> (ø)
jina/clients/base/http.py 93.18% <ø> (ø)
jina/clients/base/websocket.py 86.36% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 50.00% <ø> (ø)
jina/clients/http.py 100.00% <ø> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df5472...9a11dae. Read the comment docs.

JoanFM
JoanFM requested changes Jul 4, 2021
View reviewed changes
jina/types/score/map.py Outdated
scores: Optional[jina_pb2.NamedScoreMappingProto] = None,
copy: bool = False,
**kwargs,
scores,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the accepted types?

This was linked to issues Jul 4, 2021
AttributeError: '_RunThread' object has no attribute 'result' #2846
Closed
merge values into scores in protobuf #2848
Closed
@hanxiao hanxiao merged commit 634662a into master Jul 4, 2021
@hanxiao hanxiao deleted the fix-ci-readme-snippet branch July 4, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM requested changes

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

@maateen maateen Awaiting requested review from maateen

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/peapod component/proto component/type size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

merge values into scores in protobuf AttributeError: '_RunThread' object has no attribute 'result'
3 participants
@hanxiao @JoanFM @jina-bot