fix: rolling update and hanging fix #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR closes: #2841 |
jina-bot
added
size/S
area/core
Codecov Report
@@ Coverage Diff @@
## master #2869 +/- ##
==========================================
+ Coverage 82.21% 88.02% +5.80%
==========================================
Files 106 138 +32
Lines 7064 9500 +2436
==========================================
+ Hits 5808 8362 +2554
+ Misses 1256 1138 -118
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jina-bot
added
size/M
area/cicd
JoanFM
force-pushed
the
fix-2841
branch
4 times, most recently
from
5e94078
to
6e19483
Compare
JoanFM
requested review from
davidbp,
numb3r3,
hanxiao,
bwanglzu,
deepankarm,
florian-hoenicke,
jacobowitz and
maximilianwerk
deepankarm
reviewed
Jul 8, 2021
maximilianwerk
approved these changes
Jul 8, 2021
| # if Address already in use `self.in_sock_type` is not set | ||
| if ( | ||
| not self.is_closed | ||
| and hasattr(self, 'in_sock_type') |
There was a problem hiding this comment.
This can be removed again. I fixed the resulting error in #2853 via making sure, this is always set to None in the first place.
There was a problem hiding this comment.
will remove in follow-up PR if that's okey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced
Change the CompoundPod exit order to ExitStack to avoid sendind CANCEL to a closed HeadPea
Avoid sending
IDLEwhile flushing in_socketRetry sending control signal from Pea to runtime
Avoid copying
Peato new process by passing neededarguments. I think is dangerous to copy speciallyLoggerwith all thehandles