Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hubio): raise exception when error occurs #2904

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

mapleeit
Copy link
Member

@mapleeit mapleeit commented Jul 9, 2021

No description provided.

@mapleeit mapleeit requested a review from a team as a code owner July 9, 2021 09:36
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase labels Jul 9, 2021
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2904 (3d5a104) into master (0094bbf) will increase coverage by 6.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2904      +/-   ##
==========================================
+ Coverage   82.21%   88.76%   +6.54%     
==========================================
  Files         106      138      +32     
  Lines        7064     9533    +2469     
==========================================
+ Hits         5808     8462    +2654     
+ Misses       1256     1071     -185     
Flag Coverage Δ
daemon 43.33% <ø> (?)
jina 88.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.64% <ø> (ø)
jina/checker.py 96.55% <ø> (ø)
jina/clients/__init__.py 100.00% <ø> (ø)
jina/clients/base/__init__.py 90.90% <ø> (ø)
jina/clients/base/grpc.py 63.82% <ø> (ø)
jina/clients/base/http.py 93.18% <ø> (ø)
jina/clients/base/websocket.py 86.36% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 100.00% <ø> (ø)
jina/clients/http.py 100.00% <ø> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3598413...3d5a104. Read the comment docs.

@numb3r3 numb3r3 merged commit ea54360 into master Jul 9, 2021
@numb3r3 numb3r3 deleted the fix-hubble-raise-exception-when-error branch July 9, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants