Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: declare cors in Get Started 's FLow #2907

Merged
merged 2 commits into from
Jul 10, 2021
Merged

doc: declare cors in Get Started 's FLow #2907

merged 2 commits into from
Jul 10, 2021

Conversation

Gikiman
Copy link
Contributor

@Gikiman Gikiman commented Jul 9, 2021

doc: declare cors in Get Started 's FLow

@Gikiman Gikiman requested a review from hanxiao as a code owner July 9, 2021 10:59
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2907 (0adc855) into master (0094bbf) will increase coverage by 6.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2907      +/-   ##
==========================================
+ Coverage   82.21%   88.76%   +6.54%     
==========================================
  Files         106      138      +32     
  Lines        7064     9533    +2469     
==========================================
+ Hits         5808     8462    +2654     
+ Misses       1256     1071     -185     
Flag Coverage Δ
daemon 43.35% <ø> (?)
jina 88.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.64% <ø> (ø)
jina/checker.py 96.55% <ø> (ø)
jina/clients/__init__.py 100.00% <ø> (ø)
jina/clients/base/__init__.py 90.90% <ø> (ø)
jina/clients/base/grpc.py 63.82% <ø> (ø)
jina/clients/base/http.py 93.18% <ø> (ø)
jina/clients/base/websocket.py 86.36% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 100.00% <ø> (ø)
jina/clients/http.py 100.00% <ø> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c6af5...0adc855. Read the comment docs.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 632315f into master Jul 10, 2021
@nan-wang nan-wang deleted the README-Modified branch July 10, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants