Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no return in ChunkArray/MatchArray append #3974

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

alaeddine-13
Copy link
Contributor

closes #3971

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Nov 22, 2021
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #3974 (0f041be) into master (06126de) will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3974      +/-   ##
==========================================
+ Coverage   88.47%   89.00%   +0.52%     
==========================================
  Files         180      180              
  Lines       12667    12665       -2     
==========================================
+ Hits        11207    11272      +65     
+ Misses       1460     1393      -67     
Flag Coverage Δ
daemon 43.37% <33.33%> (+0.04%) ⬆️
jina 87.24% <100.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 70.23% <100.00%> (ø)
jina/types/arrays/chunk.py 84.00% <100.00%> (-4.47%) ⬇️
jina/types/arrays/match.py 81.81% <100.00%> (-9.49%) ⬇️
jina/executors/__init__.py 76.31% <0.00%> (-8.78%) ⬇️
jina/executors/decorators.py 92.85% <0.00%> (-5.36%) ⬇️
jina/peapods/peas/__init__.py 87.23% <0.00%> (-2.13%) ⬇️
jina/types/document/__init__.py 83.68% <0.00%> (-0.70%) ⬇️
jina/helper.py 83.48% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febc203...0f041be. Read the comment docs.

@JoanFM JoanFM merged commit fec0d42 into master Nov 23, 2021
@JoanFM JoanFM deleted the feat-no-return-chunk-match-array branch November 23, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove return from MatchArray and ChunkArray append
2 participants