Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid dependency on pydantic #4497

Merged
merged 3 commits into from
Mar 16, 2022
Merged

fix: avoid dependency on pydantic #4497

merged 3 commits into from
Mar 16, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 16, 2022

Pull Request Title

Description

Please describe what your PR is doing and why. Are there any parts which need extra attention during review? Are there any dependencies from other PRs or projcts? Is this a breaking change?

Is this PR ready or work in progress (WIP)? Ready means it can be reviewed and merged from the author's perspective. If the PR is WIP: Make it a draft PR and state open questions and TODO items.

Closes # (issue)

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina labels Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #4497 (e267007) into master (efff154) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4497      +/-   ##
==========================================
- Coverage   87.72%   87.54%   -0.18%     
==========================================
  Files         116      116              
  Lines        8458     8457       -1     
==========================================
- Hits         7420     7404      -16     
- Misses       1038     1053      +15     
Flag Coverage Δ
daemon 41.94% <33.33%> (-1.34%) ⬇️
jina 87.30% <100.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/gateway/http/models.py 99.15% <ø> (-0.01%) ⬇️
jina/__init__.py 67.46% <100.00%> (ø)
jina/serve/runtimes/gateway/http/app.py 90.67% <100.00%> (ø)
jina/serve/networking.py 71.31% <0.00%> (-11.85%) ⬇️
jina/orchestrate/pods/jinad.py 93.07% <0.00%> (-1.54%) ⬇️
jina/orchestrate/pods/__init__.py 89.93% <0.00%> (+0.62%) ⬆️
jina/serve/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.43%) ⬆️
jina/orchestrate/deployments/__init__.py 84.81% <0.00%> (+2.95%) ⬆️
jina/orchestrate/deployments/config/helper.py 98.27% <0.00%> (+12.06%) ⬆️
...rate/deployments/config/k8slib/kubernetes_tools.py 100.00% <0.00%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c2c35...e267007. Read the comment docs.

@JoanFM JoanFM merged commit 6cb0cd0 into master Mar 16, 2022
@JoanFM JoanFM deleted the require-docarray-common branch March 16, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina component/resource size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants