Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small refactor #4505

Merged
merged 1 commit into from
Mar 17, 2022
Merged

chore: small refactor #4505

merged 1 commit into from
Mar 17, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 17, 2022

Pull Request Title

Description

Please describe what your PR is doing and why. Are there any parts which need extra attention during review? Are there any dependencies from other PRs or projcts? Is this a breaking change?

Is this PR ready or work in progress (WIP)? Ready means it can be reviewed and merged from the author's perspective. If the PR is WIP: Make it a draft PR and state open questions and TODO items.

Closes # (issue)

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #4505 (57ea5e4) into master (a470ce6) will decrease coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4505      +/-   ##
==========================================
- Coverage   88.07%   87.57%   -0.51%     
==========================================
  Files         116      116              
  Lines        8528     8528              
==========================================
- Hits         7511     7468      -43     
- Misses       1017     1060      +43     
Flag Coverage Δ
daemon 41.73% <50.00%> (-1.30%) ⬇️
jina 87.32% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 67.46% <100.00%> (ø)
jina/serve/runtimes/gateway/websocket/app.py 86.95% <100.00%> (ø)
jina/serve/networking.py 71.68% <0.00%> (-11.95%) ⬇️
jina/orchestrate/deployments/__init__.py 85.44% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075b3a9...57ea5e4. Read the comment docs.

@JoanFM JoanFM merged commit ed19b73 into master Mar 17, 2022
@JoanFM JoanFM deleted the fix-pydantic-ws-2 branch March 17, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant