Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass extra search paths #4651

Merged
merged 1 commit into from
Apr 21, 2022
Merged

fix: pass extra search paths #4651

merged 1 commit into from
Apr 21, 2022

Conversation

numb3r3
Copy link
Member

@numb3r3 numb3r3 commented Apr 21, 2022

Pull Request Title

Description

The extra_search_paths in the following example is not considered:

f = Flow.load_config('clip.yml', extra_search_paths=['/path/to/folder'])
# clip.yml
jtype: Flow
version: '1'
with:
  port: 51000
executors:
  - name: clip_t
    uses:
      jtype: CLIPEncoder
      metas:
        py_modules:
          - executors/clip_torch.py

Closes # (issue)

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/jaml labels Apr 21, 2022
@numb3r3 numb3r3 requested a review from JoanFM April 21, 2022 09:17
@numb3r3 numb3r3 changed the title fix: pass extra search paths given from args fix: pass extra search paths Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #4651 (d019284) into master (73718c9) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4651      +/-   ##
==========================================
+ Coverage   87.46%   87.70%   +0.24%     
==========================================
  Files         117      117              
  Lines        8526     8526              
==========================================
+ Hits         7457     7478      +21     
+ Misses       1069     1048      -21     
Flag Coverage Δ
jina 87.70% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/__init__.py 94.38% <ø> (ø)
jina/__init__.py 67.46% <100.00%> (ø)
...a/orchestrate/deployments/config/docker_compose.py 98.97% <0.00%> (-1.03%) ⬇️
jina/helper.py 83.20% <0.00%> (-0.30%) ⬇️
jina/orchestrate/deployments/config/helper.py 98.24% <0.00%> (+1.75%) ⬆️
...deployments/config/k8slib/kubernetes_deployment.py 51.21% <0.00%> (+2.43%) ⬆️
jina/orchestrate/deployments/__init__.py 86.83% <0.00%> (+3.54%) ⬆️
...rate/deployments/config/k8slib/kubernetes_tools.py 100.00% <0.00%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 712cccb...d019284. Read the comment docs.

@numb3r3 numb3r3 merged commit 2c72e77 into master Apr 21, 2022
@numb3r3 numb3r3 deleted the fix-pass-search-paths branch April 21, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/jaml size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An exception when executing "python -m clip_server"
2 participants