Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax time constraint in block exec test #4653

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

jacobowitz
Copy link
Contributor

CI being slow made the blocking exec test fail occassionally

This PR relaxes the asserted execution time constraint a bit. Its a magic number, but I think assuming that it should take less than 2 times the expected time should be fair

@jacobowitz jacobowitz requested a review from JoanFM April 21, 2022 11:10
@github-actions github-actions bot added size/XS area/testing This issue/PR affects testing labels Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #4653 (c37f226) into master (73718c9) will decrease coverage by 1.14%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #4653      +/-   ##
==========================================
- Coverage   87.46%   86.31%   -1.15%     
==========================================
  Files         117      117              
  Lines        8526     8536      +10     
==========================================
- Hits         7457     7368      -89     
- Misses       1069     1168      +99     
Flag Coverage Δ
jina 86.31% <94.44%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/executors/decorators.py 96.96% <0.00%> (-1.52%) ⬇️
jina/serve/runtimes/monitoring.py 100.00% <ø> (ø)
jina/__init__.py 67.46% <100.00%> (ø)
jina/serve/executors/__init__.py 86.50% <100.00%> (+0.16%) ⬆️
jina/serve/networking.py 85.31% <100.00%> (-1.32%) ⬇️
jina/serve/runtimes/gateway/request_handling.py 95.71% <100.00%> (+0.12%) ⬆️
jina/serve/runtimes/head/__init__.py 93.10% <100.00%> (+0.19%) ⬆️
jina/serve/runtimes/worker/__init__.py 94.28% <100.00%> (+0.16%) ⬆️
jina/jaml/parsers/flow/v1.py 45.61% <0.00%> (-52.64%) ⬇️
jina/jaml/parsers/__init__.py 75.60% <0.00%> (-17.08%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9140b13...c37f226. Read the comment docs.

@jacobowitz jacobowitz merged commit 8a3083f into master Apr 21, 2022
@jacobowitz jacobowitz deleted the fix-block-exec-test branch April 21, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants