Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wait for floating Executor tasks #5004

Merged
merged 29 commits into from Jul 20, 2022
Merged

feat: wait for floating Executor tasks #5004

merged 29 commits into from Jul 20, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 11, 2022

Goals:

Floating Executors are not guaranteed to finish their tasks

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Jul 11, 2022
@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022 •
edited

Codecov Report

Merging #5004 (7fc28a4) into master (7e12704) will decrease coverage by 0.01%.
The diff coverage is 96.85%.

@@            Coverage Diff             @@
##           master    #5004      +/-   ##
==========================================
- Coverage   87.93%   87.92%   -0.02%     
==========================================
  Files         112      112              
  Lines        8896     8967      +71     
==========================================
+ Hits         7823     7884      +61     
- Misses       1073     1083      +10
Flag Coverage Δ
jina 87.92% <96.85%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/flow/builder.py 80.00% <ø> (ø)
jina/serve/networking.py 86.08% <90.62%> (-1.24%) ⬇️
jina/serve/runtimes/gateway/request_handling.py 95.23% <93.33%> (-0.85%) ⬇️
jina/__init__.py 64.63% <100.00%> (ø)
jina/clients/base/http.py 94.59% <100.00%> (ø)
jina/clients/base/websocket.py 90.32% <100.00%> (ø)
jina/jaml/helper.py 83.45% <100.00%> (+0.12%) ⬆️
jina/orchestrate/flow/base.py 89.84% <100.00%> (-0.56%) ⬇️
jina/orchestrate/pods/__init__.py 80.26% <100.00%> (+0.13%) ⬆️
jina/resources/health_check/gateway.py 41.17% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba1d16...7fc28a4. Read the comment docs.

@JoanFM JoanFM linked an issue Jul 11, 2022 that may be closed by this pull request
fix floating deployment #4999
Closed
@JoanFM JoanFM requested review from samsja and deepankarm July 13, 2022 07:50
samsja
samsja reviewed Jul 13, 2022
View reviewed changes
jina/clients/base/websocket.py Outdated Show resolved Hide resolved
jina/clients/base/http.py Outdated Show resolved Hide resolved
@hanxiao hanxiao mentioned this pull request Jul 13, 2022
Closed
@github-actions github-actions bot added the area/docs This issue/PR affects the docs label Jul 19, 2022
JohannesMessner
JohannesMessner suggested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@JohannesMessner JohannesMessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs only review for now, will review the code next

docs/fundamentals/flow/add-executors.md Show resolved Hide resolved
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
@JoanFM JoanFM changed the title feat: wait for hanging tasks feat: wait for floating Executor tasks Jul 20, 2022
@JoanFM @JohannesMessner
docs: apply suggestions from code review
a74453f 
Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
@JoanFM JoanFM marked this pull request as ready for review July 20, 2022 15:39
JohannesMessner
JohannesMessner previously requested changes Jul 20, 2022
View reviewed changes
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
docs/fundamentals/flow/add-executors.md Outdated Show resolved Hide resolved
JoanFM and others added 3 commits July 20, 2022 17:54
@JoanFM @JohannesMessner
docs: apply suggestions from code review
628b1d3 
Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
@JoanFM
fix: fix deploy netlify error
9bad700
@JoanFM
Merge branch 'feat-floating-exec' of https://github.com/jina-ai/jina …
7fc28a4 
…into feat-floating-exec
@JoanFM JoanFM linked an issue Jul 20, 2022 that may be closed by this pull request
deploy-netlify failing #5020
Closed
@JoanFM JoanFM closed this Jul 20, 2022
@JoanFM JoanFM reopened this Jul 20, 2022
@github-actions
Copy link

📝 Docs are deployed on https://feat-floating-exec--jina-docs.netlify.app 🎉

@JoanFM JoanFM dismissed JohannesMessner’s stale review July 20, 2022 19:30

changes taken into account

@JoanFM JoanFM merged commit 1b3edac into master Jul 20, 2022
@JoanFM JoanFM deleted the feat-floating-exec branch July 20, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsja samsja samsja left review comments

@JohannesMessner JohannesMessner JohannesMessner left review comments

@deepankarm deepankarm Awaiting requested review from deepankarm

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/client component/resource size/L size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deploy-netlify failing fix floating deployment
3 participants
@JoanFM @JohannesMessner @samsja