New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix specific params problem with branches #5038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
area/core
This issue/PR affects the core codebase
area/testing
This issue/PR affects testing
labels
Jul 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #5038 +/- ##
==========================================
- Coverage 88.02% 87.99% -0.03%
==========================================
Files 114 114
Lines 9008 9031 +23
==========================================
+ Hits 7929 7947 +18
- Misses 1079 1084 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JoanFM
force-pushed
the
fix-param-executor-branch
branch
3 times, most recently
from
July 28, 2022 09:55
147b332
to
a339669
Compare
JoanFM
force-pushed
the
fix-param-executor-branch
branch
from
July 28, 2022 10:42
a339669
to
f193148
Compare
JohannesMessner
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves an issue with
executor specific parameters
per Executor.Original problem is that
request
is concurrently altered and there are issues on how they are updated before they are sent.This problem is now solved by deepcopying the request before sending, but we have to analyze if this is the right approach since it can imply performance degradation. To solve this I added some optimizations in the code to detect when it is actually needed
Here I just want to validate this functionality would work, specially if the
__results__
handling is correct