Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix specific params problem with branches #5038

Merged
merged 5 commits into from Jul 28, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 28, 2022

Solves an issue with executor specific parameters per Executor.

Original problem is that request is concurrently altered and there are issues on how they are updated before they are sent.

This problem is now solved by deepcopying the request before sending, but we have to analyze if this is the right approach since it can imply performance degradation. To solve this I added some optimizations in the code to detect when it is actually needed

Here I just want to validate this functionality would work, specially if the __results__ handling is correct

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #5038 (726ce78) into master (b33b21f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5038      +/-   ##
==========================================
- Coverage   88.02%   87.99%   -0.03%     
==========================================
  Files         114      114              
  Lines        9008     9031      +23     
==========================================
+ Hits         7929     7947      +18     
- Misses       1079     1084       +5     
Flag Coverage Δ
jina 87.99% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/helper.py 96.55% <ø> (ø)
jina/__init__.py 64.63% <100.00%> (ø)
...ina/serve/runtimes/gateway/graph/topology_graph.py 99.45% <100.00%> (+0.02%) ⬆️
jina/serve/runtimes/gateway/request_handling.py 95.79% <100.00%> (+0.56%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/orchestrate/flow/base.py 89.88% <0.00%> (-0.57%) ⬇️
jina/clients/base/grpc.py 88.52% <0.00%> (+0.19%) ⬆️
jina/serve/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5116b92...726ce78. Read the comment docs.

@JoanFM JoanFM force-pushed the fix-param-executor-branch branch 3 times, most recently from 147b332 to a339669 Compare July 28, 2022 09:55
@JoanFM JoanFM force-pushed the fix-param-executor-branch branch from a339669 to f193148 Compare July 28, 2022 10:42
@JoanFM JoanFM marked this pull request as ready for review July 28, 2022 13:18
@JoanFM JoanFM linked an issue Jul 28, 2022 that may be closed by this pull request
@JoanFM JoanFM merged commit 032bd5e into master Jul 28, 2022
@JoanFM JoanFM deleted the fix-param-executor-branch branch July 28, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Parameters per Executor not working on Branching Flow
2 participants