Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not send target_executor to Executors #5041

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Aug 3, 2022

Goals:

Fix problem trying to connect to CaS as External Executor with target_executor parameter.

Since it is a Gateway-Gateway communication, you are actually passing the target_executor also to the second gateway, and in the external Flow, the executor may not be called the same and then it does not match any and returns the Docs unchanged.
The fix is to remove target_executor from the request once it is extracte

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Aug 3, 2022
@JoanFM JoanFM linked an issue Aug 3, 2022 that may be closed by this pull request
@JoanFM JoanFM marked this pull request as ready for review August 3, 2022 09:22
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #5041 (75c0ecd) into master (032bd5e) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5041      +/-   ##
==========================================
- Coverage   88.10%   87.99%   -0.11%     
==========================================
  Files         114      114              
  Lines        9031     9033       +2     
==========================================
- Hits         7957     7949       -8     
- Misses       1074     1084      +10     
Flag Coverage Δ
jina 87.99% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 64.63% <100.00%> (ø)
jina/serve/runtimes/gateway/request_handling.py 95.86% <100.00%> (+0.06%) ⬆️
jina/serve/runtimes/gateway/websocket/__init__.py 97.87% <0.00%> (-2.13%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/hubble/hubio.py 86.29% <0.00%> (-0.81%) ⬇️
jina/orchestrate/flow/base.py 89.88% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoanFM JoanFM merged commit 4c3d760 into master Aug 3, 2022
@JoanFM JoanFM deleted the fix-external-target branch August 3, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"target_executor" doesn't work for an external executor
2 participants