fix: add type checksum conversion of the function fetch_meta #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XS
area/core
Codecov Report
@@ Coverage Diff @@
## master #5054 +/- ##
==========================================
- Coverage 88.15% 88.04% -0.11%
==========================================
Files 115 115
Lines 9149 9149
==========================================
- Hits 8065 8055 -10
- Misses 1084 1094 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
floralatin
force-pushed
the
fix-hubble-hubio-pull
branch
from
d173538
to
22920c3
Compare
|
Have fixed by this pull request #5061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
there was a bug where pulling an Executor with build env vars would not work, because it tried to cache the keys of these env vars, but the DictKeys object can't be pickled. This PR converts these keys to a list, thus fixing the bug.
The diffs are large, but that's only because of the black.
The only relevant line is build_env=list(buildEnv.keys()) if buildEnv and isinstance(buildEnv, dict) else [], line 715 in hubio.py (and the added test).