Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(jcloud): autoscale docs #5056

Merged
merged 2 commits into from Aug 11, 2022
Merged

docs(jcloud): autoscale docs #5056

merged 2 commits into from Aug 11, 2022

Conversation

zac-li
Copy link
Member

@zac-li zac-li commented Aug 11, 2022

Changes

  • Moved contents from Basic to index.md
  • Added Autoscale
  • Added a note in docs/how-to/external-executor.md
  • Updated the note in docs/how-to/external-executor.md

@github-actions github-actions bot added size/M area/docs This issue/PR affects the docs labels Aug 11, 2022
docs/fundamentals/jcloud/index.md Show resolved Hide resolved
docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
docs/fundamentals/jcloud/index.md Show resolved Hide resolved
docs/how-to/external-executor.md Outdated Show resolved Hide resolved
docs/how-to/kubernetes.md Outdated Show resolved Hide resolved
docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
@zac-li zac-li force-pushed the knative branch 2 times, most recently from bbe7592 to 979cd7d Compare August 11, 2022 07:26
Copy link
Contributor

@JohannesMessner JohannesMessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the relationship between jinahub+serverless and setting a configuration manually? Am I understanding correctly that jinahub+serverless is just a shortcut that sets some default values? If so I think we should consider putting that part first, since it seems like the easy entry point for the user. The manual configuration setting can then come after that, as a slightly more advanced/manual way of doing it. Thoughts?

docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
docs/fundamentals/jcloud/autoscale.md Outdated Show resolved Hide resolved
@zac-li
Copy link
Member Author

zac-li commented Aug 11, 2022

@JohannesMessner Good point on jinahub+serverless, yea I think we should restructure the docs following your recommendation.

@github-actions
Copy link

📝 Docs are deployed on https://knative--jina-docs.netlify.app 🎉

@deepankarm deepankarm merged commit 0111153 into master Aug 11, 2022
@deepankarm deepankarm deleted the knative branch August 11, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue/PR affects the docs size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants