Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include jcloud cli #5074

Merged
merged 23 commits into from Aug 18, 2022
Merged

feat: include jcloud cli #5074

merged 23 commits into from Aug 18, 2022

Conversation

alaeddine-13
Copy link
Contributor

closes: #5071
Goals:

  • integrate jcloud cli into jina

@github-actions github-actions bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina labels Aug 17, 2022
@github-actions github-actions bot removed the area/setup This issue/PR affects setting up Jina label Aug 18, 2022
@github-actions github-actions bot added the area/setup This issue/PR affects setting up Jina label Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022 •
edited

Codecov Report

Merging #5074 (8ea3f43) into master (b9bddd2) will increase coverage by 1.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5074      +/-   ##
==========================================
+ Coverage   86.99%   88.04%   +1.04%     
==========================================
  Files         115      115              
  Lines        9137     9139       +2     
==========================================
+ Hits         7949     8046      +97     
+ Misses       1188     1093      -95
Flag Coverage Δ
jina 88.04% <100.00%> (+1.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 65.11% <100.00%> (ø)
jina/parsers/__init__.py 97.87% <100.00%> (+0.04%) ⬆️
jina/jaml/__init__.py 94.83% <0.00%> (+0.36%) ⬆️
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.62%) ⬆️
jina/helper.py 81.00% <0.00%> (+0.74%) ⬆️
jina/enums.py 86.31% <0.00%> (+1.05%) ⬆️
jina/jaml/helper.py 83.45% <0.00%> (+2.25%) ⬆️
jina/clients/helper.py 100.00% <0.00%> (+2.38%) ⬆️
.../runtimes/request_handlers/data_request_handler.py 94.69% <0.00%> (+3.03%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (+3.46%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the area/docs This issue/PR affects the docs label Aug 18, 2022
@alaeddine-13 alaeddine-13 marked this pull request as ready for review August 18, 2022 14:36
@hanxiao
Merge branch 'feat-jcloud-cli' of https://github.com/jina-ai/jina int…
1236d85 
…o feat-jcloud-cli

# Conflicts:
#	extra-requirements.txt
#	jina/parsers/__init__.py
@hanxiao hanxiao closed this Aug 18, 2022
@hanxiao hanxiao reopened this Aug 18, 2022
@hanxiao hanxiao closed this Aug 18, 2022
@hanxiao hanxiao reopened this Aug 18, 2022
@hanxiao hanxiao closed this Aug 18, 2022
@hanxiao hanxiao reopened this Aug 18, 2022
@github-actions
Copy link

📝 Docs are deployed on https://feat-jcloud-cli--jina-docs.netlify.app 🎉

@hanxiao hanxiao merged commit 6f87524 into master Aug 18, 2022
@hanxiao hanxiao deleted the feat-jcloud-cli branch August 18, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@JohannesMessner JohannesMessner JohannesMessner left review comments

@JoanFM JoanFM Awaiting requested review from JoanFM JoanFM is a code owner

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/setup This issue/PR affects setting up Jina component/resource size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate jcloud cli in jina
4 participants
@alaeddine-13 @hanxiao @JohannesMessner @jina-bot