Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(flow): clean up #5255

Merged
merged 3 commits into from
Oct 10, 2022
Merged

docs(flow): clean up #5255

merged 3 commits into from
Oct 10, 2022

Conversation

alexcg1
Copy link
Member

@alexcg1 alexcg1 commented Oct 7, 2022

Clean up of docs, including spelling, grammar, clarity, consistency, etc.

  • docs(flow): rm outdated video, clean up

  • docs(flow): clean up

  • check and update documentation. See guide and ask the team.

@alexcg1 alexcg1 added the area/docs This issue/PR affects the docs label Oct 7, 2022
@alexcg1 alexcg1 self-assigned this Oct 7, 2022
@alexcg1 alexcg1 requested a review from JoanFM October 7, 2022 15:10
@github-actions github-actions bot added the size/L label Oct 7, 2022
@alexcg1
Copy link
Member Author

alexcg1 commented Oct 7, 2022 •
edited

Outdated video contains old syntax style for Flows, specifying pods rather than Executors. Some info in it is (probably) still correct (e.g. how to set up syntax highlight in PyCharm), but I figure it's best to remove it since the main part (explaining our YAML) is outdated.

JoanFM
JoanFM requested changes Oct 8, 2022
View reviewed changes
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets check the Websocket naming

@github-actions
Copy link

📝 Docs are deployed on https://docs-flow-clean-up--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit bcf17c3 into master Oct 10, 2022
@JoanFM JoanFM deleted the docs-flow-clean-up branch October 10, 2022 10:22
@alexcg1 alexcg1 mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

Assignees

@alexcg1 alexcg1

Labels
area/docs This issue/PR affects the docs size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexcg1 @JoanFM