-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: put metric collection in helper methods #5337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm lets wait for the CI to pass I suggest a renaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, great refactoring
Codecov Report
@@ Coverage Diff @@
## master #5337 +/- ##
==========================================
+ Coverage 85.27% 86.62% +1.34%
==========================================
Files 97 99 +2
Lines 6413 6468 +55
==========================================
+ Hits 5469 5603 +134
+ Misses 944 865 -79
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pure refactoring PR, pulling the metrics collection for Prometheus into separate methods.