Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: put metric collection in helper methods #5337

Merged
merged 4 commits into from
Nov 1, 2022

Conversation

JohannesMessner
Copy link
Contributor

Pure refactoring PR, pulling the metrics collection for Prometheus into separate methods.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase labels Oct 31, 2022
Copy link
Contributor

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm lets wait for the CI to pass I suggest a renaming

samsja
samsja previously approved these changes Oct 31, 2022
Copy link
Contributor

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great refactoring

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #5337 (f1b6077) into master (bd80035) will increase coverage by 1.34%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master    #5337      +/-   ##
==========================================
+ Coverage   85.27%   86.62%   +1.34%     
==========================================
  Files          97       99       +2     
  Lines        6413     6468      +55     
==========================================
+ Hits         5469     5603     +134     
+ Misses        944      865      -79     
Flag Coverage Δ
jina 86.62% <96.42%> (+1.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...untimes/request_handlers/worker_request_handler.py 97.50% <96.42%> (+0.14%) ⬆️
jina/serve/instrumentation/_aio_server.py 77.14% <0.00%> (-11.43%) ⬇️
jina/serve/runtimes/gateway/websocket/gateway.py 98.21% <0.00%> (-1.79%) ⬇️
jina/resources/health_check/gateway.py 41.17% <0.00%> (ø)
jina/resources/health_check/pod.py 50.00% <0.00%> (ø)
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.61%) ⬆️
jina/serve/networking.py 87.03% <0.00%> (+0.82%) ⬆️
jina/serve/runtimes/asyncio.py 85.45% <0.00%> (+0.90%) ⬆️
jina/clients/base/websocket.py 90.19% <0.00%> (+0.98%) ⬆️
jina/clients/base/grpc.py 85.91% <0.00%> (+1.40%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JohannesMessner JohannesMessner merged commit a9ef7bc into master Nov 1, 2022
@JohannesMessner JohannesMessner deleted the refactor-worker branch November 1, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants