Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add deployment label in grpc stub metrics #5344

Merged
merged 12 commits into from Nov 7, 2022
Merged

feat: add deployment label in grpc stub metrics #5344

merged 12 commits into from Nov 7, 2022

Conversation

Jackmin801
Copy link
Contributor

@Jackmin801 Jackmin801 commented Nov 3, 2022 •
edited

Goals:

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022 •
edited

Codecov Report

Merging #5344 (c04fb2b) into master (6eb4e87) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5344      +/-   ##
==========================================
+ Coverage   86.69%   86.80%   +0.11%     
==========================================
  Files          99       99              
  Lines        6470     6488      +18     
==========================================
+ Hits         5609     5632      +23     
+ Misses        861      856       -5
Flag Coverage Δ
jina 86.80% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/networking.py 88.29% <100.00%> (+1.25%) ⬆️
jina/serve/runtimes/gateway/websocket/gateway.py 100.00% <0.00%> (+1.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the size/M label Nov 3, 2022
Jackmin801
Jackmin801 commented Nov 3, 2022
View reviewed changes
jina/serve/networking.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Nov 3, 2022
@Jackmin801 Jackmin801 marked this pull request as ready for review November 7, 2022 08:21
JoanFM
JoanFM requested changes Nov 7, 2022
View reviewed changes
jina/serve/networking.py Outdated Show resolved Hide resolved
jina/serve/networking.py Show resolved Hide resolved
girishc13
girishc13 reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@girishc13 girishc13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. We don't mention the available labels in the docs so I'm not sure if we need to update the docs.

jina/serve/networking.py Show resolved Hide resolved
jina/serve/networking.py Show resolved Hide resolved
jina/serve/networking.py
if request_type == DataRequest and len(requests) > 1:
# TODO: This section of the code has no observability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @samsja can answer why it was left out in the first implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jackmin801 what do u think is missing ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an issue has been opened

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5359

jina/serve/networking.py Show resolved Hide resolved
@Jackmin801 Jackmin801 mentioned this pull request Nov 7, 2022
Closed
girishc13
girishc13 previously approved these changes Nov 7, 2022
View reviewed changes
@JoanFM
Copy link
Member

JoanFM commented Nov 7, 2022

Good work. We don't mention the available labels in the docs so I'm not sure if we need to update the docs.

@samsja, may u assist on whether docs need to be changed?

samsja
samsja suggested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work. I added some comments

jina/serve/networking.py Outdated Show resolved Hide resolved
tests/unit/serve/instrumentation/test_gateway_metric_labels.py Outdated Show resolved Hide resolved
@Jackmin801 @samsja
fix: add type annotation
5fc6787 
Co-authored-by: samsja <55492238+samsja@users.noreply.github.com>
@samsja
Copy link
Contributor

samsja commented Nov 7, 2022

u assist on whether docs need to be changed?

No need to add them

@JoanFM JoanFM requested a review from samsja November 7, 2022 14:58
@JoanFM JoanFM merged commit c28a763 into master Nov 7, 2022
@JoanFM JoanFM deleted the feat-5154-executor-label branch November 7, 2022 14:59
@alexcg1 alexcg1 mentioned this pull request Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@girishc13 girishc13 girishc13 left review comments

@samsja samsja Awaiting requested review from samsja

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics on the gateway should always contained a label based on the Executor target
4 participants
@Jackmin801 @JoanFM @samsja @girishc13