-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix bug inheritance, requests nested dict #5380
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5380 +/- ##
==========================================
- Coverage 86.83% 85.75% -1.08%
==========================================
Files 100 101 +1
Lines 6512 6608 +96
==========================================
+ Hits 5655 5667 +12
- Misses 857 941 +84
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
b870ce5
to
0a5923d
Compare
0a5923d
to
0f7c344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment
fac8c53
to
b2b271d
Compare
Goals:
Makes
requests
Executor class method a nested dict including the class name to support inheritance