Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug inheritance, requests nested dict #5380

Merged
merged 8 commits into from
Nov 11, 2022
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Nov 11, 2022

Goals:
Makes requests Executor class method a nested dict including the class name to support inheritance

@JoanFM JoanFM linked an issue Nov 11, 2022 that may be closed by this pull request
1 task
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #5380 (33e264c) into master (de53f95) will decrease coverage by 1.07%.
The diff coverage is 98.57%.

@@            Coverage Diff             @@
##           master    #5380      +/-   ##
==========================================
- Coverage   86.83%   85.75%   -1.08%     
==========================================
  Files         100      101       +1     
  Lines        6512     6608      +96     
==========================================
+ Hits         5655     5667      +12     
- Misses        857      941      +84     
Flag Coverage Δ
jina 85.75% <98.57%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/deprecated.py 83.33% <ø> (ø)
jina/parsers/orchestrate/pod.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/head.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/remote.py 100.00% <ø> (ø)
jina/parsers/orchestrate/runtimes/runtime.py 100.00% <ø> (ø)
jina/serve/streamer.py 95.91% <ø> (ø)
jina/serve/runtimes/head/request_handling.py 95.52% <95.52%> (ø)
jina/orchestrate/flow/base.py 84.12% <100.00%> (-6.65%) ⬇️
jina/parsers/orchestrate/runtimes/worker.py 100.00% <100.00%> (ø)
jina/serve/executors/decorators.py 98.71% <100.00%> (+0.18%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Nov 11, 2022
@JoanFM JoanFM marked this pull request as ready for review November 11, 2022 11:25
nan-wang
nan-wang previously approved these changes Nov 11, 2022
Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Contributor

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

jina/serve/executors/__init__.py Outdated Show resolved Hide resolved
@JoanFM JoanFM merged commit b44d767 into master Nov 11, 2022
@JoanFM JoanFM deleted the fix-bug-inheritance branch November 11, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: wrong inherited Executor called
3 participants