docs: fix port and protocol description for the gateway #5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XS
area/core
Codecov Report
@@ Coverage Diff @@
## master #5456 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 101 101
Lines 6615 6616 +1
=======================================
+ Hits 5774 5775 +1
Misses 841 841
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
requested changes
Nov 25, 2022
| @@ -19,7 +19,7 @@ | |||
| | `ssl_certfile` | the path to the certificate file | `string` | `None` | | |||
| | `ssl_keyfile` | the path to the key file | `string` | `None` | | |||
| | `expose_graphql_endpoint` | If set, /graphql endpoint is added to HTTP interface. | `boolean` | `False` | | |||
| | `protocol` | Possible communication protocols between server and client. Depending on your chosen gateway, choose the convenient protocols from: ['GRPC', 'HTTP', 'WEBSOCKET']. | `array` | `[<GatewayProtocolType.GRPC: 0>]` | | |||
| | `protocol` | Communication protocol of the server exposed by the Gateway. Depending on your chosen Gateway, choose the convenient protocols from: ['GRPC', 'HTTP', 'WEBSOCKET']. | `array` | `[<GatewayProtocolType.GRPC: 0>]` | | |||
JoanFM
approved these changes
Nov 28, 2022
github-actions
bot
added
the
area/cli
|
📝 Docs are deployed on https://docs-fix-port-protocol-desc--jina-docs.netlify.app 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide more accurate description for port and protocol parameters of the gateway