feat: expand executor serve parameters #5494
Conversation
github-actions
bot
added
size/M
area/core
alaeddine-13
force-pushed
the
feat-executor-serve-expand-args
branch
from
c4b4047
to
c28ab9e
Compare
Codecov Report
@@ Coverage Diff @@
## master #5494 +/- ##
==========================================
+ Coverage 85.58% 87.53% +1.94%
==========================================
Files 120 121 +1
Lines 9410 9648 +238
==========================================
+ Hits 8054 8445 +391
+ Misses 1356 1203 -153
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Wait for #5488 since it touches a little bit |
jina/serve/executors/__init__.py
Outdated
| @@ -526,6 +709,7 @@ def serve( | |||
| uses_with=uses_with, | |||
| uses_metas=uses_metas, | |||
| uses_requests=uses_requests, | |||
| reload=reload, | |||
| ) | |||
There was a problem hiding this comment.
are u sure all these kwargs are passed to the Executor itself?
There was a problem hiding this comment.
I tried out the reload locally
Putting the executor definition and executor.serve() in the same file is not supported so I added a warning each time we attempt to reload the main module. In other cases it works
There was a problem hiding this comment.
kwargs are passed to the Flow. That way, the user of serve will have full power over everything (gateway + executor).
I confirm that kwargs are passed correctly to Flow and the Flow in return, passes them to gateway and executor (beisdes the ones explicitly passed to the executors)
…jina-ai/jina into feat-executor-serve-expand-args
feat: expand executor serve parameters