New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support jinaai executor scheme #5515
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5515 +/- ##
==========================================
+ Coverage 82.06% 86.06% +3.99%
==========================================
Files 121 121
Lines 9643 9642 -1
==========================================
+ Hits 7914 8298 +384
+ Misses 1729 1344 -385
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alaeddine-13
changed the title
test: cover jinaai scheme in tests
fix: support jinaai executor scheme
Dec 13, 2022
alaeddine-13
changed the title
fix: support jinaai executor scheme
feat: support jinaai executor scheme
Dec 13, 2022
JoanFM
requested changes
Dec 13, 2022
alaeddine-13
commented
Dec 13, 2022
JoanFM
previously approved these changes
Dec 14, 2022
JoanFM
previously approved these changes
Dec 14, 2022
alaeddine-13
commented
Dec 14, 2022
tests/integration/issues/github_4488/test_deployment_protocol.py
Outdated
Show resolved
Hide resolved
tests/unit/orchestrate/deployments/config/test_docker_compose_pod_config.py
Outdated
Show resolved
Hide resolved
tests/unit/orchestrate/deployments/config/test_docker_compose_pod_config.py
Outdated
Show resolved
Hide resolved
tests/unit/orchestrate/deployments/config/test_docker_compose_pod_config.py
Outdated
Show resolved
Hide resolved
tests/unit/orchestrate/flow/flow-construct/test_flow_to_k8s_yaml.py
Outdated
Show resolved
Hide resolved
JoanFM
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support and tests that cover the new
jinaai
scheme along withjinahub
scheme