Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support jinaai executor scheme #5515

Merged
merged 8 commits into from Dec 14, 2022
Merged

feat: support jinaai executor scheme #5515

merged 8 commits into from Dec 14, 2022

Conversation

alaeddine-13
Copy link
Contributor

@alaeddine-13 alaeddine-13 commented Dec 13, 2022

Add support and tests that cover the new jinaai scheme along with jinahub scheme

@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #5515 (9b91dfb) into master (bfe9a32) will increase coverage by 3.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5515      +/-   ##
==========================================
+ Coverage   82.06%   86.06%   +3.99%     
==========================================
  Files         121      121              
  Lines        9643     9642       -1     
==========================================
+ Hits         7914     8298     +384     
+ Misses       1729     1344     -385     
Flag Coverage Δ
jina 86.06% <100.00%> (+3.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/deployments/config/helper.py 90.90% <100.00%> (+6.69%) ⬆️
jina/clients/mixin.py 65.51% <0.00%> (-30.18%) ⬇️
jina/clients/request/__init__.py 88.23% <0.00%> (-11.77%) ⬇️
jina/orchestrate/pods/helper.py 82.69% <0.00%> (-7.70%) ⬇️
jina/serve/runtimes/worker/request_handling.py 84.25% <0.00%> (-6.70%) ⬇️
jina/serve/runtimes/gateway/request_handling.py 88.78% <0.00%> (-6.55%) ⬇️
jina/clients/base/grpc.py 82.97% <0.00%> (-6.39%) ⬇️
jina/serve/streamer.py 93.22% <0.00%> (-3.39%) ⬇️
jina/serve/stream/__init__.py 96.92% <0.00%> (-2.31%) ⬇️
jina/clients/base/websocket.py 87.25% <0.00%> (-1.97%) ⬇️
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the area/core This issue/PR affects the core codebase label Dec 13, 2022
@alaeddine-13 alaeddine-13 changed the title test: cover jinaai scheme in tests fix: support jinaai executor scheme Dec 13, 2022
@alaeddine-13 alaeddine-13 changed the title fix: support jinaai executor scheme feat: support jinaai executor scheme Dec 13, 2022
JoanFM
JoanFM previously approved these changes Dec 14, 2022
@JoanFM JoanFM enabled auto-merge (squash) December 14, 2022 08:36
JoanFM
JoanFM previously approved these changes Dec 14, 2022
tests/integration/sandbox/test_sandbox.py Outdated Show resolved Hide resolved
tests/unit/orchestrate/pods/test_pod_factory.py Outdated Show resolved Hide resolved
tests/unit/serve/executors/test_executor.py Outdated Show resolved Hide resolved
tests/unit/serve/executors/test_executor.py Outdated Show resolved Hide resolved
tests/unit/test_cli.py Outdated Show resolved Hide resolved
@JoanFM JoanFM merged commit 03ce8e8 into master Dec 14, 2022
@JoanFM JoanFM deleted the fix-jinaai-scheme branch December 14, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants