Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support composite gateway for k8s export #5532

Merged
merged 8 commits into from Dec 19, 2022
Merged

Conversation

alaeddine-13
Copy link
Contributor

fix: support composite gateway for k8s export

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality labels Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #5532 (4f6b8fc) into master (fe2d623) will increase coverage by 1.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5532      +/-   ##
==========================================
+ Coverage   86.33%   87.49%   +1.16%     
==========================================
  Files         122      122              
  Lines        9814     9815       +1     
==========================================
+ Hits         8473     8588     +115     
+ Misses       1341     1227     -114     
Flag Coverage Δ
jina 87.49% <100.00%> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/deployments/config/helper.py 90.90% <ø> (ø)
jina/orchestrate/deployments/config/k8s.py 100.00% <ø> (+0.61%) ⬆️
jina/__init__.py 67.39% <100.00%> (+0.35%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.03% <100.00%> (+4.34%) ⬆️
jina/jaml/__init__.py 95.00% <0.00%> (+0.35%) ⬆️
jina/orchestrate/deployments/__init__.py 90.62% <0.00%> (+0.55%) ⬆️
jina/helper.py 80.91% <0.00%> (+0.71%) ⬆️
jina/serve/runtimes/worker/request_handling.py 96.17% <0.00%> (+0.85%) ⬆️
jina/serve/gateway.py 95.23% <0.00%> (+1.58%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Dec 16, 2022
@alaeddine-13 alaeddine-13 marked this pull request as ready for review December 16, 2022 09:30
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u add an example to the k8s_tests?

@alaeddine-13
Copy link
Contributor Author

Can u add an example to the k8s_tests?

done

JoanFM
JoanFM previously approved these changes Dec 16, 2022
@github-actions github-actions bot removed area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/entrypoint This issue/PR affects the entrypoint codebase labels Dec 18, 2022
@github-actions github-actions bot added area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality labels Dec 18, 2022
@JoanFM JoanFM merged commit 3c09e6e into master Dec 19, 2022
@JoanFM JoanFM deleted the fix-composite-gateway-k8s branch December 19, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants