New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: common args inheritence from Flow API #5535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes should be in create section https://docs.jina.ai/concepts/flow/basics/#create
Also update the docstring of flow constructor (we want to see such information in the flow constructor API) |
Codecov Report
@@ Coverage Diff @@
## master #5535 +/- ##
==========================================
- Coverage 86.79% 84.21% -2.58%
==========================================
Files 122 122
Lines 9815 9815
==========================================
- Hits 8519 8266 -253
- Misses 1296 1549 +253
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@scott-martens if you have time today could you handle this? |
Documentation change looks good to me. |
📝 Docs are deployed on https://doc-flow-args--jina-docs.netlify.app 🎉 |
Goals: