fix: respect timeout_ready when generating startup probe #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
area/core
Codecov Report
@@ Coverage Diff @@
## master #5560 +/- ##
==========================================
+ Coverage 86.31% 87.47% +1.16%
==========================================
Files 123 123
Lines 9833 9840 +7
==========================================
+ Hits 8487 8608 +121
+ Misses 1346 1232 -114
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
reviewed
Dec 28, 2022
| @@ -77,6 +84,12 @@ def get_template_yamls( | |||
| else: | |||
| protocols = protocol | |||
|
|
|||
| if timeout_ready == -1: | |||
| raise ValueError( | |||
There was a problem hiding this comment.
I would perhaps maybe set some default value on our end?
|
if timeout ready is -1 lets rrmove startupProbe |
JoanFM
previously approved these changes
Dec 29, 2022
…hub.com/jina-ai/jina into fix-startup-probe-respect-timeout-ready
JoanFM
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: respect timeout_ready when generating startup probe configurations