-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect timeout_ready when generating startup probe #5560
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5560 +/- ##
==========================================
+ Coverage 86.31% 87.47% +1.16%
==========================================
Files 123 123
Lines 9833 9840 +7
==========================================
+ Hits 8487 8608 +121
+ Misses 1346 1232 -114
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -77,6 +84,12 @@ def get_template_yamls( | |||
else: | |||
protocols = protocol | |||
|
|||
if timeout_ready == -1: | |||
raise ValueError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would perhaps maybe set some default value on our end?
if timeout ready is -1 lets rrmove startupProbe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test
…hub.com/jina-ai/jina into fix-startup-probe-respect-timeout-ready
fix: respect timeout_ready when generating startup probe configurations