Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix link to docs and redocs #5883

Merged
merged 5 commits into from May 17, 2023
Merged

fix: fix link to docs and redocs #5883

merged 5 commits into from May 17, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented May 17, 2023

New behavior:

image

Old behavior:

image

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels May 17, 2023
@JoanFM JoanFM closed this May 17, 2023
@JoanFM JoanFM reopened this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #5883 (9a51456) into master (281725a) will increase coverage by 29.74%.
The diff coverage is 90.00%.

@@             Coverage Diff             @@
##           master    #5883       +/-   ##
===========================================
+ Coverage   50.69%   80.44%   +29.74%     
===========================================
  Files         140      142        +2     
  Lines       12087    12145       +58     
===========================================
+ Hits         6128     9770     +3642     
+ Misses       5959     2375     -3584     
Flag Coverage Δ
jina 80.44% <90.00%> (+29.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/base.py 100.00% <ø> (ø)
jina/serve/executors/decorators.py 92.13% <ø> (+43.25%) ⬆️
jina/orchestrate/deployments/__init__.py 82.53% <80.00%> (+40.07%) ⬆️
jina/__init__.py 56.71% <100.00%> (ø)
jina/orchestrate/flow/base.py 89.88% <100.00%> (+32.90%) ⬆️

... and 90 files with indirect coverage changes

@JoanFM JoanFM merged commit f55ae50 into master May 17, 2023
122 of 128 checks passed
@JoanFM JoanFM deleted the fix-docs-link-multiprotocol branch May 17, 2023 12:29
@JoanFM JoanFM mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants