Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the way endpoints are printed #5884

Merged
merged 3 commits into from May 18, 2023
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented May 17, 2023

Fix the issue with this behavior when no ports are provided with Deployments with multiple protocols:

import os
from jina import Deployment, Executor, requests, Client
d = Deployment(protocol=['grpc', 'http'])
with d:
    pass

Before:
image

After:

image

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels May 17, 2023
@JoanFM JoanFM closed this May 17, 2023
@JoanFM JoanFM reopened this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #5884 (8cecf80) into master (f55ae50) will increase coverage by 15.48%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #5884       +/-   ##
===========================================
+ Coverage   65.15%   80.64%   +15.48%     
===========================================
  Files         140      142        +2     
  Lines       12099    12145       +46     
===========================================
+ Hits         7883     9794     +1911     
+ Misses       4216     2351     -1865     
Flag Coverage Δ
jina 80.64% <100.00%> (+15.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/deployments/__init__.py 82.53% <100.00%> (+14.55%) ⬆️

... and 84 files with indirect coverage changes

Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM JoanFM force-pushed the fix-show-composite-protocols branch from 9871d76 to 975cba5 Compare May 18, 2023 07:20
@JoanFM JoanFM closed this May 18, 2023
@JoanFM JoanFM reopened this May 18, 2023
@JoanFM JoanFM merged commit 2ef767b into master May 18, 2023
123 of 127 checks passed
@JoanFM JoanFM deleted the fix-show-composite-protocols branch May 18, 2023 08:08
@JoanFM JoanFM mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants