New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(proto!): make document a recursive structure #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jina CLA check ✅ All Contributors have signed the CLA. |
This PR closes: #648 |
jina-bot
added
size/L
area/core
This issue/PR affects the core codebase
area/helper
This issue/PR affects the helper functionality
area/network
This issue/PR affects network functionality
area/testing
This issue/PR affects testing
component/client
component/driver
component/executor
component/proto
executor/indexer
labels
Jul 13, 2020
JoanFM
reviewed
Jul 13, 2020
JoanFM
reviewed
Jul 13, 2020
JoanFM
reviewed
Jul 14, 2020
# Conflicts: # tests/test_flow.py # tests/unit/yaml/unarycrafter.yml
Will solve #669 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/core
This issue/PR affects the core codebase
area/docs
This issue/PR affects the docs
area/helloworld
This issue/PR affects the helloworld
area/helper
This issue/PR affects the helper functionality
area/network
This issue/PR affects network functionality
area/testing
This issue/PR affects testing
component/client
component/driver
component/executor
component/proto
component/resource
executor/crafter
executor/indexer
size/XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimated Done 25th July
This will be part of v0.5.0
Current test progress
Intro
This will be a super big PR with breaking changes. Simply put, it removes the protobuf spec of "Chunk". Now, a "Chunk" is defined as a "Document" that belongs to another "Document". Hence, "Document" is now a recursive structure. One can visit chunks via
doc.chunks
and get childrenList[Document]
This is an upgrade over the previous "Document/Chunk" concept. It makes the whole thing more general, enables advance segmenting and matching (#648)
Affects
chunk
-related drivers/executors are removed because the interface is now unified.Breakdown
Chunk
.BaseRecursiveDriver
that works on single doc recursively in preorder and postoder.BaseRecursiveDriver
Migration guide (draft)
level
is not required in all drivers anymore.PruneDriver
is nowExcludeQL
, nolevel
is required,excludes
->fields
, e.g.DocPruneDriver
is removed, one can now useChunkPruneDriver
is removed, one can now use the following, as one can see it is basically the same asDocPruneDriver
, just with different fields.BaseCraftDriver
is nowCraftDriver
.DocCraftDriver
andChunkCraftDriver
are removeddoc_id
andchunk_id
are unified asid
nowUnarySegmentDriver
is removed. NowEncodeDriver
works directly on doc-level embedding,extract_chunks
is now refactored asextract_docs
works on root-level extraction (previously it works ondoc.chunks
level extraction)BaseChunkCrafter
andBaseDocCrafter
are removed.TopkFilterDriver
is removed and now is implemented with Query Language:ChunkPbIndex
andDocPbIndexer
are now removed, please useBinaryPbIndexer
ReqPruneDriver
is removed now use_merge_topk_docs
->_merge_all