Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Copy time.Time not working #78

Closed
maeglindeveloper opened this issue Feb 12, 2021 · 7 comments
Closed

[Bug] Copy time.Time not working #78

maeglindeveloper opened this issue Feb 12, 2021 · 7 comments
Assignees

Comments

@maeglindeveloper
Copy link

Reproducible Example

https://play.golang.org/p/pbA2Z1XJotV

Description

Hi everyone,

I'm not abble to copy structure of type time.Time.
See the example above.

Thanks in advance @jinzhu @math-nao

@matthieujoossen
Copy link

This seems to be due to DeepCopy option (https://play.golang.org/p/NX2p8crN7se)

matthieujoossen pushed a commit to matthieujoossen/copier that referenced this issue Feb 18, 2021
jinzhu added a commit that referenced this issue Mar 9, 2021
[fix] #78 Note that a copy was made after successful copy
@jinzhu jinzhu closed this as completed Mar 10, 2021
tomtwinkle pushed a commit to tomtwinkle/copier that referenced this issue Mar 19, 2021
@maeglindeveloper
Copy link
Author

maeglindeveloper commented Apr 15, 2021

@jinzhu, @matthieujoossen , this is not fixed I think, see the following example
https://play.golang.org/p/VTtlVj1D0N5

@maeglindeveloper
Copy link
Author

@jinzhu any thoughts on this ? :)

@maeglindeveloper
Copy link
Author

@jinzhu, any solution on this ?
This is still not fixed. See the following code
https://go.dev/play/p/Lrcq_MhsH7t

@maeglindeveloper
Copy link
Author

Hmmmm, my bad, it seems that this PR https://github.com/jinzhu/copier/pull/113 fixes this issue but it is not yet released
@jinzhu do you have any ETA for the 0.3.5 release?
Thanks for all :)

@jinzhu
Copy link
Owner

jinzhu commented Jan 23, 2022

Hi @maeglindeveloper

Sorry for the delay, done that.

@maeglindeveloper
Copy link
Author

Perfect @jinzhu , thank you so much for the work you are doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants