Page tracking endpoint added #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All integrations now respond to the page-endpoint * Documentation updated
jipiboily
reviewed
Nov 9, 2016
| @@ -17,6 +17,11 @@ func (fi FakeIntegration) Track(event integrations.Event) error { | |||
| } | |||
|
|
|||
| // Enabled returns wether or not the integration is enabled/configured | |||
| func (fi FakeIntegration) Page(page integrations.Page) error { | |||
There was a problem hiding this comment.
Comment for that one is wrong :)
| @@ -10,6 +10,8 @@ type Integration interface { | |||
| // Track forwards the event to the integration | |||
| Track(event Event) error | |||
|
|
|||
| Page(page Page) error | |||
There was a problem hiding this comment.
A comment is missing for that one.
| @@ -74,3 +76,43 @@ func (e Event) Validate() (missingParameters []string) { | |||
| } | |||
| return | |||
| } | |||
|
|
|||
| type Page struct { | |||
jonashelgemo
commented
Nov 9, 2016
| @@ -44,6 +45,7 @@ func (i Identification) Validate() (missingParameters []string) { | |||
| return | |||
| } | |||
|
|
|||
| // Event defines the structure for the incoming event data from the API | |||
There was a problem hiding this comment.
Added this as well as it was missing :)
|
Should be fixed now. Merge when you are ready :) |
|
@helgeblod there you go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't update the README as the track-endpoint is not documentet there either. Might be a good idea to document the api as the api grows, but maybe it should be done using a tool that is more apropriate (eg http://raml.org/ or similar)