collect: do not symlink the same file

[jalavik]

• Avoids an OSError that may happen when the source and
  destination is pointing to the same file.

Signed-off-by: Jan Aage Lavik jan.age.lavik@cern.ch

[greut]

@jalavik how is that even happening? Can you tell me what is your app.static_folder? (See: invenio.base.factory:create_app]

[jalavik]

@greut: Good question. It happened when I was running collect after checking out a branch that had renamed a static file. This patch avoids the error, although maybe it can be fixed differently.

In [1]: current_app.static_folder
Out[1]: '/home/jlavik/envs/pudemosite/var/invenio.base-instance/static'

I dunno if you guys have noticed, but often the Travis build fails on 2.6 for me with:

I'm sorry but your test run exceeded 50.0 minutes. 
One possible solution is to split up your test run.

[greut]

@jalavik my call is that the source should never be in .../var/invenio.base-instance/static and the destination always. I don't see how they can be identical.

travis Yep, too many tests printing stack traces and logs ;-)

[jirikuncar]

@jalavik Please tell us how to reproduce the issue. Thanks

[jalavik]

@greut Yeah, well it happens :-)

Perhaps you can try to reproduce it by running inveniomanage collect on pu. Then check out my branch workflows-dev from https://github.com/jalavik/invenio and run inveniomanage collect.

[jalavik]

Why close it when it is still being discussed?

[greut]

@jalavik probably, can you post (via gist, not here) the console output of the collect call (with your modification or with a way to know which files are the troublemakers). Thanks!

[jirikuncar]

@jalavik Can you create an issue for it? Here we are suppose to discuss code. Thank you.

[jalavik]

Solved in #245 Thanks!