Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper XML library #6

Closed
robertvazan opened this issue Jun 28, 2018 · 1 comment
Closed

Use proper XML library #6

robertvazan opened this issue Jun 28, 2018 · 1 comment

Comments

@robertvazan
Copy link

Parameter separator (&) in an URL will be literally written into the output, producing malformed XML. There are likely many other issues with such hand-coded XML serialization. You should use some existing XML library like jdom2 or even the built-in Java XML API.

jirkapinkas pushed a commit that referenced this issue Dec 26, 2018
@jirkapinkas
Copy link
Owner

fixed malformed XML, but won't use any library, because:

  1. In the past I wanted to rewrite jsitemapgenerator to use JAXB, but in Java 9 JAXB was removed from Java core.
  2. I want to minimize number of dependencies, zero dependencies is for this kind of library ideal
  3. And last: I would have to rewrite tests and I don't really want to do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants