Upgrade JSHint to 2.5.4 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we vendored + patched a copy of JSHint each time we needed to upgrade. This commit takes a plain copy of JSHint and adapts PreCommit to use JSHint out of the box. This should make future JSHint upgrades much easier :)
|
looks good to me ;) |
| @@ -5,7 +5,7 @@ module Checks | |||
| class Jshint < Js | |||
|
|
|||
| def js_config | |||
| if config_file | |||
| @js_config ||= if config_file | |||
There was a problem hiding this comment.
Do you use this js_config outside this class? Can it be made private?
|
+1, looks legit, left some minor notes. The build's broken though? |
When appending JavaScript it is considered best practice to include an initial semi-colon to ensure the concatenated content does not collide.
|
💇 updated with suggestions I'm not sure what to do about the JRuby test failures. Should we drop JRuby from Travis for the time being? |
|
+1. Maybe mark the jruby build as optional in the travis matrix? I haven't looked at the failure myself, so take that as a light suggestion. |
|
|
jruby issue jruby/jruby#1945 - will be fixed in |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we vendored + patched a copy of
JSHinteach time we needed to upgrade. This commit takes a plain copy ofJSHintand adaptsPreCommitto useJSHintout of the box.This should make future
JSHintupgrades much easier :)@shajith @mpapis @mwerner
Closes #157