Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android-sdk.md #404

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Update android-sdk.md #404

merged 1 commit into from
Dec 22, 2022

Conversation

NilabhB
Copy link
Contributor

@NilabhB NilabhB commented Dec 17, 2022

When allprojects{} is missing in build.gradle, set the maven repository in settings.gradle.

When `allprojects{}` is missing in `build.gradle`, set the maven repository in `settings.gradle`.
@saghul
Copy link
Member

saghul commented Dec 18, 2022

Even if the section is missing it can be added, can't it?

@NilabhB
Copy link
Contributor Author

NilabhB commented Dec 18, 2022

Hi,

I tried all possibilities, without implementing it on settings.gradle the gradle building is not successful. Currently in newer projects gradle.build contains only the plugins{}. Even if we manually drop the block of codes there, it will through some error. I overcome it by replacing it on settings.gradle.

Either way allprojects{} seems to be obsolete now, so I thought of updating it.

@saghul
Copy link
Member

saghul commented Dec 18, 2022

What Gradle version obsoletes it? We should have both and mention which Gradle version requires the new syntax, since not everyone will be running the new version day one.

@NilabhB
Copy link
Contributor Author

NilabhB commented Dec 18, 2022

Yes, you are right. I am not sure from which gradle version allprojects{} is removed but I can say that gradle version 7.4 doesn't have the allprojects{}. Previous versions of gradle (eg. 6.7.1) use to have allprojects{}. Now in gradle version 7.4 build.gradle consists of only the plugins{} by default (checked by creating a new project).

As you have said, not everyone will start from day one, if they find the allprojects{} in the build.gradle they will follow the old process only, in case they can't find it then they will implement it in settings.gradle, this is what I requested for merging. I haven't removed the old conventional process from the handbook, just added the alternatives for newer versions.

@saghul saghul merged commit 618947a into jitsi:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants