Updates jibri pjsua part #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes capture device id.
Chrome uses default audio device.
These can be configured in pjsua.config.
The capture and playback devices indexes are based on latest asoundrc config: Found 16 devices 0: ALSA [amix] (0/1) 1: ALSA [asnoop] (1/0) 2: ALSA [aduplex] (1/1) 3: ALSA [bmix] (0/1) 4: ALSA [bsnoop] (1/0) 5: ALSA [bduplex] (1/1) 6: ALSA [pjsua] (1/1) 7: ALSA [default] (1/1) 8: ALSA [hw:CARD=Loopback,DEV=0] (1/1) 9: ALSA [hw:CARD=Loopback,DEV=1] (1/1) 10: ALSA [plughw:CARD=Loopback,DEV=0] (1/1) 11: ALSA [plughw:CARD=Loopback,DEV=1] (1/1) 12: ALSA [hw:CARD=Loopback_1,DEV=0] (1/1) 13: ALSA [hw:CARD=Loopback_1,DEV=1] (1/1) 14: ALSA [plughw:CARD=Loopback_1,DEV=0] (1/1) 15: ALSA [plughw:CARD=Loopback_1,DEV=1] (1/1)
saghul
previously approved these changes
Nov 28, 2019
| --no-vad | ||
| --ec-tail 0 | ||
| --quality 10 | ||
| #--auto-answer-timer=30 |
There was a problem hiding this comment.
If you use sip-jibri from the xmpp side, not sure how it will act ...
There was a problem hiding this comment.
But then it won't work on the other case... I guess it's ok for now, but maybe we should move those to back the Java side so it can be made functional both ways without changes?
--max-calls can stay
| #--auto-answer=200 | ||
| #--max-calls=1 | ||
| --no-stderr | ||
| --log-file=/tmp/pjsua.out |
There was a problem hiding this comment.
/var/log/jibri/pjsua.log while we are at it?
| @@ -34,7 +34,17 @@ data class SipClientParams( | |||
| * Whether auto-answer is enabled, if it is, the client will listen for | |||
| * incoming invites and will auto answer the first one. | |||
| */ | |||
| val autoAnswer: Boolean = false | |||
| val autoAnswer: Boolean = false, | |||
There was a problem hiding this comment.
Are we planning on supporting the non auto-answer case?
There was a problem hiding this comment.
This is the xmpp side triggering this, as it creates a sip call.
When running from java we seems to block the stdout writing of pjsua and hang the app, launching it from a script seems to avoid that.
damencho
force-pushed
the
upass-pjsua
branch
from
c84759e
to
203ce85
Compare
saghul
reviewed
Nov 28, 2019
| @@ -6,7 +6,7 @@ After=network.target | |||
| User=jibri | |||
| Group=jibri | |||
| Environment=DISPLAY=:0 | |||
| ExecStart=/usr/bin/Xorg -nocursor -noreset +extension RANDR +extension RENDER -logfile /tmp/xorg.log -config /etc/jitsi/jibri/xorg-video-dummy.conf :0 | |||
| ExecStart=/usr/bin/Xorg -nocursor -noreset +extension RANDR +extension RENDER -logfile /var/log/xorg.log -config /etc/jitsi/jibri/xorg-video-dummy.conf :0 | |||
There was a problem hiding this comment.
Since this X server is for Jibri I'd put the log file in /var/log/jitsi/jibri
saghul
previously approved these changes
Nov 28, 2019
saghul
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.