Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix ktlint errors. #448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Nov 2, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #448 (194d3a5) into master (fcce53b) will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #448      +/-   ##
============================================
+ Coverage     47.42%   47.45%   +0.02%     
  Complexity      173      173              
============================================
  Files            71       71              
  Lines          1887     1888       +1     
  Branches        186      186              
============================================
+ Hits            895      896       +1     
  Misses          927      927              
  Partials         65       65              
Impacted Files Coverage Δ
...n/kotlin/org/jitsi/jibri/selenium/JibriSelenium.kt 18.42% <0.00%> (ø)
...in/org/jitsi/jibri/sipgateway/pjsua/PjsuaClient.kt 0.00% <0.00%> (ø)
...si/jibri/service/impl/FileRecordingJibriService.kt 74.25% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcce53b...194d3a5. Read the comment docs.

Copy link
Member

@JonathanLennox JonathanLennox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have the code to check these automatically?

@bgrozev
Copy link
Member Author

bgrozev commented Nov 3, 2021

Do we not have the code to check these automatically?

I suspect it's running with a different version of ktlint (since we still use maven-antrun-plugin in jibri), because I got a disjoint set of errors locally and on GH. The tests passed, so this change satisfies both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants