Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit video senders #827

Merged
merged 6 commits into from
Nov 9, 2021
Merged

Limit video senders #827

merged 6 commits into from
Nov 9, 2021

Conversation

jqdrqgnq
Copy link
Contributor

@jqdrqgnq jqdrqgnq commented Nov 9, 2021

Keep track of the number of video senders in a conference, that is, the number of participants who have unmuted their video source. When the limit is reached, return an error if another participant attempts to unmute their video.

This is an attempt to avoid issues that may arise from the storm of signaling that may occur when a large number of participants unmute at the same time.

Fix build - add stub functions to other derived classes.
Use implicit reference from inner class.
Do lazy evaluation of hasVideo.
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #827 (fb9e5b8) into master (931b95a) will decrease coverage by 0.36%.
The diff coverage is 6.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #827      +/-   ##
============================================
- Coverage     44.90%   44.53%   -0.37%     
+ Complexity      756      752       -4     
============================================
  Files           111      111              
  Lines          6527     6572      +45     
  Branches        920      928       +8     
============================================
- Hits           2931     2927       -4     
- Misses         3188     3233      +45     
- Partials        408      412       +4     
Impacted Files Coverage Δ
...a/org/jitsi/impl/protocol/xmpp/ChatMemberImpl.java 0.00% <0.00%> (ø)
...ava/org/jitsi/impl/protocol/xmpp/ChatRoomImpl.java 0.00% <0.00%> (ø)
...itsi/jicofo/conference/source/EndpointSourceSet.kt 78.26% <0.00%> (-1.74%) ⬇️
...tlin/org/jitsi/jicofo/xmpp/muc/ChatRoomListener.kt 33.33% <0.00%> (-4.17%) ⬇️
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 43.87% <7.69%> (-0.74%) ⬇️
...c/main/kotlin/org/jitsi/jicofo/ConferenceConfig.kt 92.85% <100.00%> (+0.35%) ⬆️
...si/jicofo/conference/AbstractChannelAllocator.java 39.08% <0.00%> (-3.45%) ⬇️
...itsi/protocol/xmpp/AbstractOperationSetJingle.java 54.18% <0.00%> (-1.68%) ⬇️
...rc/main/kotlin/org/jitsi/jicofo/jibri/BaseJibri.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931b95a...fb9e5b8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants