-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit video senders #827
Merged
Merged
Limit video senders #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail a video source-add once the limit is reached.
bgrozev
reviewed
Nov 9, 2021
src/main/kotlin/org/jitsi/jicofo/conference/source/EndpointSourceSet.kt
Outdated
Show resolved
Hide resolved
bgrozev
reviewed
Nov 9, 2021
src/main/java/org/jitsi/jicofo/conference/JitsiMeetConferenceImpl.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
============================================
- Coverage 44.90% 44.53% -0.37%
+ Complexity 756 752 -4
============================================
Files 111 111
Lines 6527 6572 +45
Branches 920 928 +8
============================================
- Hits 2931 2927 -4
- Misses 3188 3233 +45
- Partials 408 412 +4
Continue to review full report at Codecov.
|
bgrozev
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of the number of video senders in a conference, that is, the number of participants who have unmuted their video source. When the limit is reached, return an error if another participant attempts to unmute their video.
This is an attempt to avoid issues that may arise from the storm of signaling that may occur when a large number of participants unmute at the same time.