chore: remove unnecessary debian 10 appimage fix #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian 11 (bullseye) changed the default for kernel.unprivileged_userns_clone to 1, thus this workaround is no longer required. This at the same time fixes the default command line entry for the deb package. Closes: #628
|
I tested this on Debian 11 and Fedora 35, all good. Ubuntu always had kernel.unprivileged_userns_clone to 1, so they were never affected in the first place and thus dont need this as well. Thus I suggest to drop this (and with that drop support for running the AppImage on Debian 10). |
saghul
approved these changes
Dec 5, 2021
d3473r
pushed a commit
to d3473r/jitsi-meet-electron
that referenced
this pull request
Sep 1, 2023
Debian 11 (bullseye) changed the default for kernel.unprivileged_userns_clone to 1, thus this workaround is no longer required. This at the same time fixes the default command line entry for the deb package. Closes: jitsi#628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian 11 (bullseye) changed the default for kernel.unprivileged_userns_clone to 1 (see https://www.debian.org/releases/bullseye/amd64/release-notes/ch-information.en.html#linux-user-namespaces).
Thus this workaround is no longer required, remove it.
This at the same time fixes the default command line entry for the deb package.
Closes: #628