Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share): avoid disconnect when transitioning to full remote #548

Merged
merged 2 commits into from Sep 10, 2019
Merged

fix(share): avoid disconnect when transitioning to full remote #548

merged 2 commits into from Sep 10, 2019

Commits on Sep 9, 2019

  1. fix(share): avoid disconnect when transitioning to full remote 

    Move back disconnect logic into remote-control.js
so disconnection happens on unmount of it, instead
of on unmount of withRemote. Otherwise, when share
mode is exited, withRemote's unmount will fire
and disconnect the remote.
    Leonard Kim committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    ad1d2e1 View commit details
    Browse the repository at this point in the history

  2. fix(webdriver): share mode exist looks for more specific remote view 

    Instead of looking for the generic remote-control view,
look for the specific expected subview.
    Leonard Kim committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    cc754ab View commit details
    Browse the repository at this point in the history