Apply comments to this PR

jitsi · Feb 23, 2017 · bf3dab0 · bf3dab0
1 parent 4182a7c
commit bf3dab0
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 21 deletions.
diff --git a/css/_variables.scss b/css/_variables.scss
@@ -129,8 +129,13 @@ $linkFontColor: #489afe;
 $linkHoverFontColor: #287ade;
 
 /**
- * Landing
+ * Unsupported browser
  */
 $primaryUnsupportedBrowserButtonBgColor: #17a0db;
 $unsupportedBrowserButtonBgColor: #ff9a00;
 $unsupportedBrowserTextColor: #4a4a4a;
+$unsupportedBrowserTitleColor: #fff;
+$unsupportedBrowserTitleFontSize: 24px;
+$unsupportedDesktopBrowserTextColor: rgba(255, 255, 255, 0.7);
+$unsupportedDesktopBrowserTextFontSize: 21px;
+$unsupportedBrowserTextSmallFontSize: 17px;
diff --git a/css/unsupported-browser/_no-mobile-app.scss b/css/unsupported-browser/_no-mobile-app.scss
@@ -9,12 +9,12 @@
         border-bottom: 1px solid $auiBorderColor;
         font-weight: 400;
         letter-spacing: 0.5px;
-        color: #fff;
+        color: $unsupportedBrowserTitleColor;
     }
 
     &__description {
         margin-top: 1em;
-        font-size: 17px;
+        font-size: $unsupportedBrowserTextSmallFontSize;
         font-weight: 300;
         letter-spacing: 1px;
     }

diff --git a/css/unsupported-browser/_unsupported-desktop-browser.scss b/css/unsupported-browser/_unsupported-desktop-browser.scss
@@ -5,22 +5,22 @@
     text-align: center;
 
     &__title {
-        color: #fff;
+        color: $unsupportedBrowserTitleColor;
         font-weight: 300;
-        font-size: 24px;
+        font-size: $unsupportedBrowserTitleFontSize;
         letter-spacing: 1px;
     }
 
     &__description {
         margin-top: 16px;
-        color: rgba(255, 255, 255, 0.7);
+        color: $unsupportedDesktopBrowserTextColor;
         font-weight: 300;
-        font-size: 21px;
+        font-size: $unsupportedDesktopBrowserTextFontSize;
         letter-spacing: 1px;
 
         &_small {
             @extend .unsupported-desktop-browser__description;
-            font-size: 16px;
+            font-size: $unsupportedBrowserTextSmallFontSize;
         }
     }
 

diff --git a/react/features/unsupported-browser/components/NoMobileApp.js b/react/features/unsupported-browser/components/NoMobileApp.js
@@ -5,7 +5,7 @@ import React, { Component } from 'react';
 declare var interfaceConfig: Object;
 
 /**
- * React component representing no mobile page.
+ * React component representing no mobile app page.
  *
  * @class NoMobileApp
  */
@@ -25,8 +25,8 @@ export default class NoMobileApp extends Component {
                     Video chat isn't available in the mobile apps
                 </h2>
                 <p className = { `${ns}__description` }>
-                    Please use { interfaceConfig.APP_NAME } on <br />
-                    Desktop top join calls.
+                    Video chat isn't available on mobile
+                    Desktop to join calls.
                 </p>
             </div>
         );

diff --git a/react/features/unsupported-browser/components/PluginRequiredBrowser.js b/react/features/unsupported-browser/components/PluginRequiredBrowser.js
@@ -18,6 +18,7 @@ export default class PluginRequiredBrowser extends Component {
      */
     render() {
         const ns = 'unsupported-desktop-browser';
+        const nsLink = `${ns}__link`;
 
         return (
             <div className = { ns }>
@@ -30,13 +31,13 @@ export default class PluginRequiredBrowser extends Component {
                     however, we strongly recommend that you do that using
                     the&nbsp;
                     <a
-                        className = { `${ns}__link` }
+                        className = { nsLink }
                         href = { BROWSER_LINKS.CHROME }>Chrome</a>,&nbsp;
                     <a
-                        className = { `${ns}__link` }
+                        className = { nsLink }
                         href = { BROWSER_LINKS.CHROMIUM }>Chromium</a> or&nbsp;
                     <a
-                        className = { `${ns}__link` }
+                        className = { nsLink }
                         href = { BROWSER_LINKS.FIREFOX }>Firefox</a> browsers.
                 </p>
             </div>

diff --git a/react/features/unsupported-browser/components/UnsupportedDesktopBrowser.js b/react/features/unsupported-browser/components/UnsupportedDesktopBrowser.js
@@ -18,25 +18,26 @@ export default class UnsupportedDesktopBrowser extends Component {
      */
     render() {
         const ns = 'unsupported-desktop-browser';
+        const nsLink = `${ns}__link`;
 
         return (
             <div className = { ns }>
                 <h2 className = { `${ns}__title` }>
                     It looks like you're using a browser we don't support.
                 </h2>
                 <p className = { `${ns}__description` }>
-                    Please try again with&nbsp;
+                    Please try again with the latest version of&nbsp;
                     <a
-                        className = { `${ns}__link` }
+                        className = { nsLink }
                         href = { BROWSER_LINKS.CHROME } >Chrome</a>,&nbsp;
                     <a
-                        className = { `${ns}__link` }
+                        className = { nsLink }
                         href = { BROWSER_LINKS.FIREFOX }>Firefox</a>,&nbsp;
                     <a
-                        className = { `${ns}__link` }
+                        className = { nsLink }
                         href = { BROWSER_LINKS.SAFARI }>Safari</a> or&nbsp;
                     <a
-                        className = { `${ns}__link` }
+                        className = { nsLink }
                         href = { BROWSER_LINKS.IE }>IE</a>.
                 </p>
             </div>

diff --git a/react/features/unsupported-browser/components/browserLinks.js b/react/features/unsupported-browser/components/browserLinks.js
@@ -9,8 +9,8 @@ const BROWSER_LINKS = {
     CHROME: 'http://google.com/chrome',
     CHROMIUM: 'http://www.chromium.org/',
     FIREFOX: 'http://www.getfirefox.com/',
-    SAFARI: 'https://support.apple.com/downloads/safari',
-    IE: 'https://www.microsoft.com/en-us/download/internet-explorer.aspx'
+    IE: 'https://www.microsoft.com/en-us/download/internet-explorer.aspx',
+    SAFARI: 'https://support.apple.com/downloads/safari'
 };
 
 export default BROWSER_LINKS;