Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User authentication during a conference not working #10796

Closed
shenziro opened this issue Jan 17, 2022 · 7 comments · Fixed by #11336
Closed

User authentication during a conference not working #10796

shenziro opened this issue Jan 17, 2022 · 7 comments · Fixed by #11336

Comments

@shenziro
Copy link

shenziro commented Jan 17, 2022

Description:

Guests cannot authenticate during a conference to get moderator rights.

Steps to reproduce:

(I hope the labels for the buttons are correct - we are not using english for our installation.)

  1. During a conference open the Settings dialog
  2. In tab Profile and click the Login button
  3. Enter your credentials
  4. Sign in

Expected behavior:

Sign in and get moderator rights.

Actual behavior:

No sign in happens and no moderator rights are granted. You can retry it multiple times.

Server information:

  • Jitsi Meet version: docker-jitsi-meet stable-6726-1
  • Operating System: Ubuntu 18.04 LTS

Client information:

  • Browser / app version: recent versions of Google Chrome and Firefox
  • Operating System: Windows 10 / Fedora 35

Additional information:

Log output in the developer-console:
2022-01-17T09:47:57.656Z [modules/xmpp/xmpp.js] <P.connectionHandler>: My Jabber ID: correct jabber id/some token?

We use the internal authentication - not ldap.

@gpatel-fr
Copy link

I confirm that this is not working either on recent unstable (6824). Trying to debug it, I have seen that the problem is at this point in authentication/components/web/LoginDialog.js:

149         if (conference) {
150             dispatch(authenticateAndUpgradeRole(jid, password, conference));
151         } else {
152             this.setState({
153                 loginStarted: true
154             });
155 
156             connect(jid, password, roomName)
157                 .then(connection => {
158                     onSuccess && onSuccess(connection);
159                 })
160                 .catch(() => {
161                     this.setState({
162                         loginStarted: false
163                     });
164                 });

connect succeeds but 'onSuccess' is undefined. I have no more time today to hunt for it, but a cursory search has found nothing to initialize this variable. So the authentication is working fine (I tested in Prosody log), but Jitsi-meet has decided to do nothing with it.

@gpatel-fr
Copy link

Tested: 5870 (may 2021) and 5765 (april 2021): identical problem. tested: 5390-3 (january 2021): works.
This functionality is broken since one full year and no one has complained.

@0xnor0
Copy link

0xnor0 commented Jan 18, 2022

We only recently updated to the latest versions and only now have noticed the problem. The old versions work fine.

@gpatel-fr
Copy link

@0xnor0 : latest ? what does that mean ? we know that 6726 has the problem. What was the last working version for you ?

@0xnor0
Copy link

0xnor0 commented Jan 19, 2022

@gpatel-fr The last working version (for us) was 5390, after that we didn't update. After upgrading to version 6689 we noticed that it's not working anymore.

pull bot pushed a commit to e4basil/jitsi-meet that referenced this issue Jan 28, 2022
* fix: Fixes jitsi#10796 authentication in conference.

* fixup!

* fixup2!

Co-authored-by: Saúl Ibarra Corretgé <saghul@jitsi.org>
@0xnor0
Copy link

0xnor0 commented Feb 18, 2022

Thank you for the fix. the authentication is working again. Sadly moderator rights are not handed over when a moderator leaves and no other moderator is present until somebody authenticate himself. Is this intended?

@saghul
Copy link
Member

saghul commented Feb 18, 2022

Yep in authenticated environments that's how it works.

ankit-programmer pushed a commit to ankit-programmer/jitsi-meet that referenced this issue May 7, 2022
* fix: Fixes jitsi#10796 authentication in conference.

* fixup!

* fixup2!

Co-authored-by: Saúl Ibarra Corretgé <saghul@jitsi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants