Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android build released on F-Droid #1290

Closed
kerpan opened this issue Feb 3, 2017 · 52 comments
Closed

Android build released on F-Droid #1290

kerpan opened this issue Feb 3, 2017 · 52 comments

Comments

@kerpan
Copy link

@kerpan kerpan commented Feb 3, 2017

It would be great to have the jitsi meet build released on F-Droid. Is there any plan to release it there?

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Feb 13, 2017

@kerpan

This comment has been minimized.

Copy link
Author

@kerpan kerpan commented Feb 17, 2017

Yes, this is the inclusion how-to and this is the inclusion policy. Would be really great to have it there!

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Feb 17, 2017

Thanks! I'll check those out.

@GitanHubert

This comment has been minimized.

Copy link

@GitanHubert GitanHubert commented Feb 19, 2017

Meet Jitsi on F-Droid : Very good suggestion.

@lanodan

This comment has been minimized.

Copy link

@lanodan lanodan commented Apr 14, 2017

Or even have a link to download the APK. (I had to download it like warez, WTF)

@Tony-il-Capo

This comment has been minimized.

Copy link

@Tony-il-Capo Tony-il-Capo commented Jun 12, 2017

Or even have a link to download the APK. (I had to download it like warez, WTF)

Yes, same here... a very bad process of getting an open source app.

@robinpaulson

This comment has been minimized.

Copy link

@robinpaulson robinpaulson commented Jul 10, 2017

Someone has asked the F-droid maintainers to include Jitsi in the repository. The issue is here:
https://gitlab.com/fdroid/rfp/issues/73

It would be appreciated if you could assist with any issues which come up, for instance dependencies, binary blobs, build scripts, etc.

Cheers,

Robin

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Jul 10, 2017

@robinpaulson Thanks for doing that Robin! I left a comment in case they need our help.

@lanodan @Tony-il-Capo We currently only provide it via the Play store, but of course you can compile it yourself.

@lanodan

This comment has been minimized.

Copy link

@lanodan lanodan commented Jul 19, 2017

@saghul
Downloading via Google is not a solution. (specially if you don’t have Google installed)
Building android apps is a horrible mess, specially if your OS/distro is not like debian/ubuntu. (And I’m used to compile things)

Seriously I fail to see how that can be considered okay, I hope I misunderstood.

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Jul 19, 2017

@lanodan Time is not infinite, so we do what we can given time constraints. "It never rains to everyone's taste", I'm afraid.

Our currently supported distribution mechanism is the Play Store. Period. F-Droid is in the works, as you read above, but that's out of our control. I did volunteer to help in any capacity required but I haven't been contacted back. You can try to download the APK from one of those APK mirrors, though I cannot recommend one. And last, you can compile it yourself.

If none of the above work for you, I'm sorry, but there is nothing I can do to help you.

@vn971

This comment has been minimized.

Copy link

@vn971 vn971 commented Jul 24, 2017

lanodan, you can also use gplaycli on Linux or yalp from F-Droid to download apk-s.

@saghul Thanks for your work, I hope F-Droid guys or enthusiasts will reply to you in time. I personally stick to F-Droid and have a very, very limited number of apps outside of F-Droid. This is because fdroid is a serious and respected review stage, passing which means the app is compatible with a lot of requirements (all of which I agree to).

@robinpaulson

This comment has been minimized.

Copy link

@robinpaulson robinpaulson commented Jul 26, 2017

@saghul I appreciate you getting in touch on the f-droid issues page. As you may have worked out, there is a bit of a backlog for adding apps to f-droid. If you are interested in helping out, there is a process to speed things along, I will see if I can find the links and post them here.

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Jul 26, 2017

@vn971 I didn't know about gplaycli, it looks useful, thanks! Also, I don't disagree with anything you said :-)

@robinpaulson Thanks! What kind of help would be needed?

@robinpaulson

This comment has been minimized.

Copy link

@robinpaulson robinpaulson commented Jul 26, 2017

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Jul 26, 2017

@robinpaulson Sweet! I'll give it a try this weekend if time allows!

@robinpaulson

This comment has been minimized.

Copy link

@robinpaulson robinpaulson commented Sep 8, 2017

@saghul Are you getting on OK with the inclusion in gitlab? If you need help, do ask!

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Sep 8, 2017

Alas I'm quite swamped right now, so I never got the chance to look at it... yet!

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Sep 28, 2017

+1

On 09/28/2017 03:36 PM, Lyubomir Marinov wrote:

Dear F-Droid proponents,

The desire to have Jitsi Meet for Android released in F-Droid has been
duly noted at #1290. I'd
encourage you to please "react" there with "+1" so that it's easier
for us to track how hot a feature request is.

Why is Jitsi Meet for Android not released in F-Droid yet? Because:
(1) We're releasing on both Android and iOS so taking on a third
release process requires additional and repetitive involvement on our
side.
(2) Having F-Droid build our young source code base in which builds
are not reproducible yet and (3) which also links with
Fabric/Crashlytics are not trivial matters.

(I personally want Jitsi Meet for Android on Amazon Appstore as well.)

Best regards,
Lyubo Marinov

@labiloute

This comment has been minimized.

Copy link

@labiloute labiloute commented Oct 1, 2017

+1 !

@jpggithub

This comment has been minimized.

Copy link

@jpggithub jpggithub commented Oct 30, 2017

+1

5 similar comments
@sjjh

This comment has been minimized.

Copy link

@sjjh sjjh commented Dec 24, 2017

+1

@mvgorcum

This comment has been minimized.

Copy link

@mvgorcum mvgorcum commented Jan 16, 2018

+1

@luke1987515

This comment has been minimized.

Copy link

@luke1987515 luke1987515 commented Jan 16, 2018

+1

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Jan 16, 2018

+1

@ddevault

This comment has been minimized.

Copy link

@ddevault ddevault commented Jan 16, 2018

+1

@vn971

This comment has been minimized.

Copy link

@vn971 vn971 commented Jan 16, 2018

Guys, there is a "react with emoji" action instead of +1. Even though I completely agree with the need to have an F-Droid build.

@narcisgarcia

This comment has been minimized.

Copy link

@narcisgarcia narcisgarcia commented Mar 27, 2018

+1

@robinpaulson

This comment has been minimized.

Copy link

@robinpaulson robinpaulson commented May 17, 2018

F-Droid is in the works, as you read above, but that's out of our control. I did volunteer
to help in any capacity required but I haven't been contacted back.

They won't contact you back; there are so many requests and so few maintainers, anything which requires even the tiniest effort beyond an app with a simple process gets put to one side. Not ideal, but their time is limited and there are 276 open requests for app inclusion.

As I understand it, now that you have been made aware of the requirements, they will expect you (or someone else) to make pull requests for the app list repository on gitlab.

I get that your time is limited though, particularly with Play Store, iOS, etc. pressures. Unless someone here prepares the pull requests, it's likely not going to happen.

@tuxayo

This comment has been minimized.

Copy link

@tuxayo tuxayo commented Jun 6, 2018

@strk

please please please. A friend did not want to install jitsi on Android because she doesn't want to give private data. We were disappointed to not find it on f-droid :(

Circumvention: use Yalp Store instead of the Play Store https://f-droid.org/en/packages/com.github.yeriomin.yalpstore/

No Google account needed.

@narcisgarcia

This comment has been minimized.

Copy link

@narcisgarcia narcisgarcia commented Jul 31, 2018

Tried to install Jitsi with Yalp on Cyanogenmod 12.1 but environment tools (Trebuchet, Catapult, Yalp itself) crashed completely.
Luckily I could open a terminal to remove with:

su
pm list packages | grep jitsi
pm uninstall org.jitsi...
@Perflyst

This comment has been minimized.

Copy link

@Perflyst Perflyst commented Nov 23, 2018

Any updates on this?

@mvglasow

This comment has been minimized.

Copy link

@mvglasow mvglasow commented Jan 20, 2019

I am currently working on a build recipe for F-Droid and I have a few questions:

The instructions at https://github.com/jitsi/jitsi-meet/blob/master/doc/mobile.md tell me to use react-native run-android to build the APK, install it on a connected Android device and launch it. How can I just build an unsigned release APK, without installing or launching anything? (And where would I then find the APK?) I have tried cd'ing to the android subdir and running gradle there, but this fails with:

* Where:
Build file '/builds/mvglasow/Navit-fdroid/fdroiddata/build/org.jitsi.meet/android/build.gradle' line: 73

* What went wrong:
A problem occurred configuring project ':react-native-background-timer'.
> Failed to notify project evaluation listener.
   > /builds/mvglasow/Navit-fdroid/fdroiddata/build/org.jitsi.meet/node_modules/react-native-background-timer/package.json (No such file or directory)

(Tested with 10624e8.)

Also, how can I tell which git commits correspond to an official release (i.e. one that would go on the Play Store)? Are they tagged in some way? I see two types of tags, nnnn (number) and jitsi-meet_nnnn, do any of those tags correspond to releases? Or is there another way to tell automatically?

@Rudloff

This comment has been minimized.

Copy link

@Rudloff Rudloff commented Jan 20, 2019

/builds/mvglasow/Navit-fdroid/fdroiddata/build/org.jitsi.meet/node_modules/react-native-background-timer/package.json (No such file or directory)

It looks like NPM dependencies were not installed.

You might want to have a look at how we build other React Native apps on F-Droid.
We don't use the react-native command and instead do something like this manually:

npm install
cd android
gradle assemble

(But Jitsi Meet might have some additional build steps.)

@mvglasow

This comment has been minimized.

Copy link

@mvglasow mvglasow commented Jan 20, 2019

@Rudloff great to see you here! Do you happen to have any examples of other React Native apps on F-Droid? (I wasn’t even aware Jitsi Meet was not the only one…)

@Rudloff

This comment has been minimized.

Copy link

@Rudloff Rudloff commented Jan 20, 2019

You can check the following build recipes:

  • com.lesspass.android
  • de.fragdenstaat.app
  • com.mdroid
@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Jan 21, 2019

For all intents and purposes our use of React Native can be counted as anecdotal. It's an implementation detail. You can build it as a regular Android package. The extra step you need to fllow is installing all dependencies with npm i.

If you make a debug build, however, you'd need to start the React Native packager, but you don't need that.

We currently have no tag for mobile releases but are about to start doing it (next release will have one).

@mvglasow

This comment has been minimized.

Copy link

@mvglasow mvglasow commented Jan 21, 2019

Anecdotal… well, you do need React Native installed to build it :-)

Re tags for mobile releases, will they follow a particular pattern? F-Droid can do some regex-based filtering, so if there were e.g. a prefix used for all mobile releases (and only for those), that would be quite easy.

@mvglasow

This comment has been minimized.

Copy link

@mvglasow mvglasow commented Jan 21, 2019

@Rudloff I tried one of those build recipes. I had to run npm install with sudo or else it would fail. The truncate/rm operations fail because the respective files are not found, so I just appended || true to see what happens afterwards. After that, the build process fails with the same error as above.

This might be related to my CI setup, I’ve documented details at https://gitlab.com/mvglasow/fdroiddata/issues/1 and would be grateful if you could take a look.

@Rudloff

This comment has been minimized.

Copy link

@Rudloff Rudloff commented Jan 21, 2019

I just noticed the app uses several non-free libraries:

implementation 'com.google.firebase:firebase-core:16.0.6'

This will prevent the app from being included in F-Droid as we require included libraries to be FOSS.

@mvglasow

This comment has been minimized.

Copy link

@mvglasow mvglasow commented Jan 21, 2019

Is there any way to build Jitsi Meet without FCM? If not, that would be a blocker.

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Jan 21, 2019

Anecdotal… well, you do need React Native installed to build it :-)

Not really, you need all npm dependencies installed, and RN is distributed in as an npm package, so I don't see the problem there. Can you clarify?

Re tags for mobile releases, will they follow a particular pattern? F-Droid can do some regex-based filtering, so if there were e.g. a prefix used for all mobile releases (and only for those), that would be quite easy.

Yes. We haven't decided exactly on the pattern, but it will be a consistent one.

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Jan 21, 2019

Is there any way to build Jitsi Meet without FCM? If not, that would be a blocker.

Yes and no. FCM is not a hard requirement, so a build time toggle to disable it would be ok. I wonder if we can do it with this variable:

boolean googleServicesEnabled = project.file('google-services.json').exists()

Then here: https://github.com/jitsi/jitsi-meet/blob/master/android/app/src/main/java/org/jitsi/meet/MainActivity.java#L194 we'll need to use the full package notation to avoid the imports.

I think that would be all.

I'll keep this in mind and take care of it as time allows, but if someone wants to send a PR, that would be most welcome.

@webmind

This comment has been minimized.

Copy link

@webmind webmind commented Jan 22, 2019

Would be very welcome for me as well, yalp needs a google account here and gplaycli don't work for me on ubuntu bionic and I've got a google-free smartphone.

Thanks!

@vn971

This comment has been minimized.

Copy link

@vn971 vn971 commented Jan 24, 2019

@webmind offtopic, but Yalp certainly doesn't require a personal google account. There were some occasions when it was laggy, but otherwise it works just fine (using built-in accounts). Retrying later helps at times.

@rasos

This comment has been minimized.

Copy link
Contributor

@rasos rasos commented Apr 11, 2019

Could we have an F-Droid version without Google Crashlytics and Firebase Analytics? See https://reports.exodus-privacy.eu.org/en/reports/37219/

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Apr 30, 2019

I've made some progress on this. #4155 allows to build Jitsi Meet without any analytics nor Google Play Services.

If I can get this landed by in the next Jitsi Meet version (19.2.0) it would be the right time to restart the F-Drop release effort, by taking that tag and rebuilding it with the LIBRE_BUILD env var.

@raphj

This comment has been minimized.

Copy link

@raphj raphj commented Jul 5, 2019

@PanderMusubi

This comment has been minimized.

Copy link

@PanderMusubi PanderMusubi commented Sep 3, 2019

See also #4588

@saghul

This comment has been minimized.

Copy link
Member

@saghul saghul commented Nov 25, 2019

@saghul saghul closed this Nov 25, 2019
@PanderMusubi

This comment has been minimized.

Copy link

@PanderMusubi PanderMusubi commented Nov 25, 2019

I think, this is one to announce on social media, reddit, irc, etc.

@PanderMusubi

This comment has been minimized.

Copy link

@PanderMusubi PanderMusubi commented Nov 25, 2019

See also #4891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.